Closed
Bug 1044768
Opened 10 years ago
Closed 10 years ago
Error page: link to "list of open bugs" seems too generic
Categories
(Webtools Graveyard :: Elmo, defect)
Webtools Graveyard
Elmo
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Assigned: akshaytiwari.003, Mentored)
Details
(Whiteboard: [good-first-bug])
Attachments
(1 file)
When hitting an error page, I get a "Feel like hacking" section with a link to "list of open bugs", which seems way too generic https://bugzilla.mozilla.org/buglist.cgi?quicksearch=%22[good+first+bug]%22+%22[dashboard]%22 I'm not sure where the "good first bug" part is expected, but I also find only two bugs with [dashboard] in the subject. Maybe just point the link to open bugs for Elmo? https://bugzilla.mozilla.org/buglist.cgi?resolution=---&component=Elmo&product=Webtools
Comment 1•10 years ago
|
||
We should use https://bugzilla.mozilla.org/buglist.cgi?o1=isnotempty&f1=bug_mentor&resolution=---&query_format=advanced&component=Elmo&product=Webtools Code location is at https://github.com/mozilla/elmo/blob/0e7587a5448aaa8f21dc1bb32b432f26e4ae0d74/templates/500.html#L15
Mentor: l10n
Whiteboard: [good-first-bug]
Assignee | ||
Comment 2•10 years ago
|
||
According to Axels comment, ive changed the url to alt url given by him.
Attachment #8468615 -
Flags: review?(axel)
Comment 3•10 years ago
|
||
Comment on attachment 8468615 [details] [review] I've linked it to bugs list url Hi Akshay, thanks for helping out. The patch is a great start, there are three follow-ups that I'd like you to do still: - rebase the patch on top of the develop branch. We're using gitflow [1], which means that master is only used for production. - remove the &list_id=10933731 from the link. That part of the URL is added by bugzilla to create your own version of that query. - update the text in the link. I think that "list of mentored bugs" would be better. Technically, I'm using two bugzilla identities for different parts of my mozilla work, for this part, please use l10n@mozilla.com. The axel@pike.org is just for my personal bugs. [1] http://nvie.com/posts/a-successful-git-branching-model/
Attachment #8468615 -
Flags: review?(axel) → feedback+
Updated•10 years ago
|
Assignee: nobody → akshaytiwari.003
Reporter | ||
Comment 4•10 years ago
|
||
Shouldn't the & be encoded as & in the template?
Comment 5•10 years ago
|
||
Yes, good catch.
Assignee | ||
Comment 6•10 years ago
|
||
https://github.com/mozilla/elmo/pull/10 I've fixed the url as you people suggested me to. Let me know if it works .
Comment 7•10 years ago
|
||
Commits pushed to develop at https://github.com/mozilla/elmo https://github.com/mozilla/elmo/commit/858132efbf96eb3466629057b3f6148d5880c6e6 Update 500.html Regarding the bug 1044768. Points the bugs list for elmo https://github.com/mozilla/elmo/commit/0ac019bc994b7794c68c811fc5434a63af6bb958 bug 1044768, update link text, r=me
Comment 8•10 years ago
|
||
Comment on attachment 8468615 [details] [review] I've linked it to bugs list url I've followed this up with a commit to fix the link text, too. Also rebased and squashed and stuff.
Attachment #8468615 -
Flags: review+
Comment 9•10 years ago
|
||
Thanks Akshay for your help. I've rebased and follow-up-ed a bit on your patch. I'd be happy for you to pick up more of our easy bugs. We're not working with pull requests, though, and not on master. https://github.com/mozilla/elmo/wiki/Contribute#summary has the technical details.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•10 years ago
|
||
Thanks for introducing gitflow to me Axel. I'm really thankful to you. I shall learn this as soon as possible and start working on bugs. Thank you.
Updated•4 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•