Update test_gallery_view to use 'portrait' instead of 'portrait-primary'

RESOLVED WONTFIX

Status

Firefox OS
Gaia::UI Tests
RESOLVED WONTFIX
4 years ago
4 years ago

People

(Reporter: Bebe, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Our gallery tests are failing because the device are positioned upside down (With the USB plug up) because of space reasons.

In the gallery test we check the screen orientation and we expect it to be "portrait-primary" and currently it's "portrait-secondary"

Because of that we see failing tests in our runs.

Update the test to check that the orientation is: "portrait"
(Reporter)

Updated

4 years ago
See Also: → bug 1042032
(Reporter)

Comment 1

4 years ago
Created attachment 8463358 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22214

Can you guys take a look over this and see if it's OK
Attachment #8463358 - Flags: feedback?(zcampbell)
Attachment #8463358 - Flags: feedback?(dave.hunt)

Comment 2

4 years ago
Dylan plans to move them all up the other way but I'll try and get a handle on the timeframe and get back to you. It'd be better to keep this test the way it is.
Comment on attachment 8463358 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22214

I don't have a problem if this is our only option, but I would prefer to either keep the devices the right way up, or to force the initial orientation in the test setUp. Making the test itself more vague is the least desirable solution.
Attachment #8463358 - Flags: feedback?(dave.hunt) → feedback-
The cables have been ordered, and once they get here we will flip all the devices right side up.

Comment 5

4 years ago
Let's not do this solution.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX

Updated

4 years ago
Attachment #8463358 - Flags: feedback?(zcampbell)
You need to log in before you can comment on or make changes to this bug.