Closed
Bug 1045046
Opened 11 years ago
Closed 10 years ago
Handle manual sync event and broadcast to registered cloudsync adapters
Categories
(Cloud Services Graveyard :: cloudSync, defect)
Cloud Services Graveyard
cloudSync
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: akligman, Assigned: akligman)
References
Details
Attachments
(1 file, 5 obsolete files)
|
2.18 KB,
patch
|
akligman
:
review+
|
Details | Diff | Splinter Review |
When the user syncs manually, cloudsync adapters should be notified through a listener on cloudSync.adapters.
|
Assignee | |
Comment 1•10 years ago
|
||
The "Sync Now" menu item is only visible when FxAccounts is logged in. Looks like it replaces the setup menu item. If "Sync Now" is visible when cloudsync adapters are loaded, will that be confusing if "Set-up Sync" is also there for FxAccounts? Thoughts?
Flags: needinfo?(rfeeley)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Spoke with jgruen about this. Current plan is to enable manual sync UI when cloudsync adapters are present. There are enough other ways to set up fxaccounts sync.
Flags: needinfo?(rfeeley)
Flags: needinfo?(jgruen)
|
|
Assignee | |
Comment 4•10 years ago
|
||
This is what I'm thinking. Does it look reasonable?
Attachment #8476745 -
Flags: feedback?(jgruen)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Oops, I meant this one.
Attachment #8476745 -
Attachment is obsolete: true
Attachment #8476745 -
Flags: feedback?(jgruen)
Attachment #8476750 -
Flags: feedback?(jgruen)
|
||
Comment 6•10 years ago
|
||
(In reply to Alan K [:ack] from comment #5)
> Created attachment 8476750 [details] [diff] [review]
> cloudsync-ui.patch
>
> Oops, I meant this one.
Yes, reasonable
|
|
Assignee | |
Comment 7•10 years ago
|
||
Land 993584 first.
Attachment #8476750 -
Attachment is obsolete: true
Attachment #8476750 -
Flags: feedback?(jgruen)
Attachment #8481447 -
Flags: review?(jgruen)
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
Can we get a Try run for this and the other cloudsync bugs?
Flags: needinfo?(akligman)
Keywords: checkin-needed
|
|
Assignee | |
Comment 9•10 years ago
|
||
Flags: needinfo?(akligman)
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 10•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [cloudsync] → [cloudsync][fixed-in-fx-team]
|
|
||
Comment 11•10 years ago
|
||
sorry had to backout in https://tbpl.mozilla.org/?tree=Fx-Team&rev=48b63c04b664 since i guess that one of this changesets caused https://tbpl.mozilla.org/php/getParsedLog.php?id=47317116&tree=Fx-Team
Whiteboard: [cloudsync][fixed-in-fx-team] → [cloudsync]
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8481447 -
Flags: review?(jgruen) → review?(ttaubert)
|
|
Assignee | |
Comment 12•10 years ago
|
||
Attachment #8481447 -
Attachment is obsolete: true
Attachment #8481447 -
Flags: review?(ttaubert)
Attachment #8485477 -
Flags: review?(ttaubert)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8485477 -
Flags: review?(ttaubert) → review?(rnewman)
|
||
Comment 13•10 years ago
|
||
Comment on attachment 8485477 [details] [diff] [review]
0001-Bug-1045046-Handle-manual-sync-event-and-broadcast-t.patch
Review of attachment 8485477 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry that it took me so long :/
::: browser/base/content/browser-syncui.js
@@ +2,4 @@
> # License, v. 2.0. If a copy of the MPL was not distributed with this
> # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>
> +Cu.import("resource://gre/modules/XPCOMUtils.jsm");
XPCOMUtils is probably already imported by browser.js.
Attachment #8485477 -
Flags: review+
|
|
||
Updated•10 years ago
|
OS: Linux → All
Hardware: x86_64 → All
|
|
Assignee | |
Comment 14•10 years ago
|
||
Attachment #8485477 -
Attachment is obsolete: true
Attachment #8485477 -
Flags: review?(rnewman)
Attachment #8485739 -
Flags: review+
|
|
Assignee | |
Comment 15•10 years ago
|
||
Attachment #8485739 -
Attachment is obsolete: true
Attachment #8485741 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
||
Comment 16•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [cloudsync] → [cloudsync][fixed-in-fx-team]
|
|
||
Comment 17•10 years ago
|
||
sorry had to backout this change in https://tbpl.mozilla.org/?tree=Fx-Team&rev=1951712e6147 since one of this checkins seems to have caused https://tbpl.mozilla.org/php/getParsedLog.php?id=47669697&tree=Fx-Team
Whiteboard: [cloudsync][fixed-in-fx-team] → [cloudsync]
|
|
Assignee | |
Comment 18•10 years ago
|
||
This patch isn't causing the test failure. Can you land this one again?
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 19•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [cloudsync] → [cloudsync][fixed-in-fx-team]
|
|
||
Comment 20•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [cloudsync][fixed-in-fx-team] → [cloudsync]
Target Milestone: --- → Firefox 35
|
||
Updated•10 years ago
|
Component: Sync → cloudSync
Product: Firefox → Mozilla Services
Whiteboard: [cloudsync]
Target Milestone: Firefox 35 → ---
Version: Trunk → unspecified
|
||
Updated•2 years ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•