1045091 - Fix some bad implicit constructors in gfx

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[(no longer active)]

Attachment: Fix some bad implicit constructors in gfx

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 8463434 [details] [diff] [review]
Fix some bad implicit constructors in gfx

Review of attachment 8463434 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine but you're going to break the standalone moz2d build so forwarding to bas.

Comment 3

[(no longer active)]

(In reply to Benoit Girard (:BenWa) from comment #2)
> This looks fine but you're going to break the standalone moz2d build so
> forwarding to bas.

No, I'm not.  MOZ_IMPLICIT is defined in mfbt/Attributes.h, which is included in the standalone moz2d builds as well.

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 8463434 [details] [diff] [review]
Fix some bad implicit constructors in gfx

Review of attachment 8463434 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I can tell MOZ_IMPLICIT is defined inside MFBT so it should be fine for the stand-alone build. (Well, I need to update MFBT since it's new but that's a default part of my merging routine so that's fine) Any reason you think this will break the stand-alone build? As far as I can tell this is fine. Not that I shouldn't probably be reviewing this anyway :).

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f79da5afbaaf

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f79da5afbaaf