Closed Bug 1045091 Opened 8 years ago Closed 8 years ago

Fix some bad implicit constructors in gfx

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: explicit
Attachment #8463434 - Flags: review?(bgirard)
Comment on attachment 8463434 [details] [diff] [review]
Fix some bad implicit constructors in gfx

Review of attachment 8463434 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine but you're going to break the standalone moz2d build so forwarding to bas.
Attachment #8463434 - Flags: review?(bgirard) → review?(bas)
(In reply to Benoit Girard (:BenWa) from comment #2)
> This looks fine but you're going to break the standalone moz2d build so
> forwarding to bas.

No, I'm not.  MOZ_IMPLICIT is defined in mfbt/Attributes.h, which is included in the standalone moz2d builds as well.
Comment on attachment 8463434 [details] [diff] [review]
Fix some bad implicit constructors in gfx

Review of attachment 8463434 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I can tell MOZ_IMPLICIT is defined inside MFBT so it should be fine for the stand-alone build. (Well, I need to update MFBT since it's new but that's a default part of my merging routine so that's fine) Any reason you think this will break the stand-alone build? As far as I can tell this is fine. Not that I shouldn't probably be reviewing this anyway :).
Attachment #8463434 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/f79da5afbaaf
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.