1045110 - nsMemoryReporterManager.cpp:103:39: warning: suggest parentheses around assignment used as truth value [-Wparentheses]

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Daniel Holbert [:dholbert]]

Newish build warning:
{
 xpcom/base/nsMemoryReporterManager.cpp: In function 'nsresult GetProcSelfSmapsPrivate(int64_t*)':
 xpcom/base/nsMemoryReporterManager.cpp: suggest parentheses around assignment used as truth value
 xpcom/base/nsMemoryReporterManager.cpp:103:39: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
       while (ptr = strstr(ptr, "Private")) {
                                         ^
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: add a layer of parens

This patch adds a layer of parens (which suppresses the compiler's "= vs == in while condition" concern).

Comment 2

[Jan Keromnes [:janx]]

Comment on attachment 8463466 [details] [diff] [review]
fix: add a layer of parens

Review of attachment 8463466 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing the warning! This file is outside my jurisdiction, forwarding the review to Nicholas.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v1a [r=njn] (updated reviewer in commit message)

Thanks! Tree's closed; reuploading patch with reviewer adjusted, and using checkin-needed.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2047ca9ae242

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2047ca9ae242

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2047ca9ae242