1045241 - Make memory reporting for LocationService more normal

Status: RESOLVED FIXED

(Core :: DMD, defect)

Description

[Andrew McCreight [:mccr8]]

For some reason, the SizeOf methods of LocationService don't take MallocSizeOf arguments, but just directly call into a fixed MallocSizeOf function.  This prevents it from being used in other places.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Make memory reporting for LocationService more normal.

Comment 2

[Andrew McCreight [:mccr8]]

I also tried to convert it the style of the method itself to something matching more what you see elsewhere, so any nits with regards to that are welcome.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Make memory reporting for LocationService more normal.

Somehow I managed to mess up the indentation.

Comment 4

[Andrew McCreight [:mccr8]]

try run: https://tbpl.mozilla.org/?tree=Try&rev=4ccdf4dd033a

Comment 5

[Nicholas Nethercote [inactive]]

Comment on attachment 8464142 [details] [diff] [review]
Make memory reporting for LocationService more normal.

Review of attachment 8464142 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/replace/dmd/DMD.cpp
@@ +652,1 @@
>        // Don't measure mLibrary because it's externally owned.

Probably move this comment to above the declaration of |n|.

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Nicholas Nethercote [:njn] from comment #5)
> Probably move this comment to above the declaration of |n|.

Done.

https://hg.mozilla.org/integration/mozilla-inbound/rev/11f68c58e5db

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/11f68c58e5db

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/11f68c58e5db