Closed Bug 1045350 Opened 11 years ago Closed 5 years ago

The leak logging does not catch classes with spaces in their names

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: khuey, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

The regex the leak logging runs expects that a class name will have no spaces in it. We should probably change to expecting a fixed number of characters.
Actually, we're not really leaking anything. 14:18:20 INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, default process 1274 14:18:20 INFO - |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->| 14:18:20 INFO - Per-Inst Leaked Total Rem Mean StdDev Total Rem Mean StdDev 14:18:20 INFO - 0 TOTAL 23 0 371272899 0 (56695.80 +/- 86865.53) 631304363 0 ( 6405.85 +/- 13019.74) 14:18:20 INFO - 243 FilterNodeLightingSoftware<PointLight, D 192 0 3 0 ( 0.50 +/- 0.55) 201 0 ( 1.49 +/- 0.52) 14:18:20 INFO - 244 FilterNodeLightingSoftware<PointLight, S 464 0 4 0 ( 0.50 +/- 0.53) 148 0 ( 1.47 +/- 0.53) 14:18:20 INFO - 245 FilterNodeLightingSoftware<SpotLight, Sp 768 0 2 0 ( 0.50 +/- 0.58) 14 0 ( 1.36 +/- 0.62) 14:18:20 INFO - nsTraceRefcnt::DumpStatistics: 1497 entries 14:18:20 INFO - TEST-PASS | leakcheck | no leaks detected! We're just failing to consume those lines because they don't match the regex.
Assignee: nobody → continuation
OS: Windows 7 → All
Hardware: x86_64 → All

The regexp for the class name in process_single_leak_file got fixed at some point, it looks like.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.