1045413 - PuppetWidget always requests IME selection and text change notifications

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

The code is here:

http://mxr.mozilla.org/mozilla-central/source/widget/xpwidgets/PuppetWidget.cpp#567

The comment for these flags says they may be expensive if an HTML editor has focus:

http://mxr.mozilla.org/mozilla-central/source/widget/nsIWidget.h#206

I wonder if this is why typing emails in Gmail seems sluggish in e10s?

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Have you profiled gmail usage? Is it latency for keyboard events from parent to child + painting
which takes time or do we really do extra work?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

While typing an email I see ~1.6% under PuppetWidget::NotifyIMEOfTextChange

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Painting seems to take most of the time.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

If we need to avoid, we need to support synchronous query content event support even on e10s. They are used for caching the content data in TabParent.

Anyway, text change performance should be improved. It's always enabled in TSF mode on Windows and on Android.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Is this still problem in the latest Nightly? I added a lot of improvements around this issue. I cannot say the demerit of enabling to notify IME of text changes is 0, but I feel current build is enough fast.

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I don't see any difference in performance anymore.