Closed Bug 1045500 Opened 5 years ago Closed 5 years ago

Crash reporter notification cuts off OpenH264 plugin name

Categories

(Firefox :: General, defect)

defect
Not set
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 34
Iteration:
34.1
Tracking Status
firefox33 --- verified
firefox34 --- verified

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Our browser-plugins.js code tries to make plugin names less awkward by, among other things, stripping version numbers from the end.
We need to avoid that for the openh264 case though, because we get "...h264" → "...h".

We could just mark GMP crashes in the custom event code and then skip  makeNicePluginName() for them in browser-plugins.
Flags: firefox-backlog+
Moving this out of bug 1043531 because it doesn't block QA for that bug and hence shouldn't block it from landing ASAP.
Whiteboard: [openh264-uplift]
Hi Georg, would you like this added to Iteration 34.1?
Flags: needinfo?(georg.fritzsche)
Yes, looking into it today.
Flags: needinfo?(georg.fritzsche)
Status: NEW → ASSIGNED
QA Whiteboard: [qa?]
QA Whiteboard: [qa?] → [qa+]
Attachment #8463912 - Flags: review?(rjesup)
Attachment #8463913 - Flags: review?(ttaubert) → review+
Attachment #8463912 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/56cc07922391
https://hg.mozilla.org/mozilla-central/rev/efa72f3380cf
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Hi Liz, can a QA contact be assigned for verification of this bug.
Flags: needinfo?(lhenry)
Assigning to Anthony since this blocks bug 1043531.
Flags: needinfo?(lhenry)
QA Contact: anthony.s.hughes
Comment on attachment 8463912 [details] [diff] [review]
Mark up GMP crash events

Approval Request Comment
[Feature/regressing bug #]: OpenH264 crash reporting, frontend.
[User impact if declined]: Cut-off plugin name (e.g. "gmpopenh" instead of "gmpopenh264").
[Describe test coverage new/current, TBPL]: Manually tested, automated tested pending other bugs.
[Risks and why]: Low-risk, 2 small changes: one that just marks an event as GMP specific and another that skips processing the name if that marker is set.
[String/UUID change made/needed]: None.
Attachment #8463912 - Flags: approval-mozilla-aurora?
Comment on attachment 8463913 [details] [diff] [review]
Skip makeNicePluginname for GMP plugins

Approval Request Comment

See above.
Attachment #8463913 - Flags: approval-mozilla-aurora?
Attachment #8463912 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8463913 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Hi Georg, Florin has asked for details on how to verify this bug.  Can you provide him with that.
Flags: needinfo?(georg.fritzsche)
Steps will be up on bug 1043531 in a bit, this bug only fixes the name being cut off there.
Flags: needinfo?(georg.fritzsche)
Verified as fixed with Aurora 33.0a2 (Build ID: 20140731004002) and Nightly 34.0a1 (Build ID: 20140731030206) builds on Windows 7 x64, Mac OS X 10.9.4 and Ubuntu 13.04 64bit - the plugin name is no longer cut off in crash reporter notification.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]
Whiteboard: [openh264-uplift]
You need to log in before you can comment on or make changes to this bug.