1045500 - Crash reporter notification cuts off OpenH264 plugin name

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Georg Fritzsche [:gfritzsche]]

Our browser-plugins.js code tries to make plugin names less awkward by, among other things, stripping version numbers from the end.
We need to avoid that for the openh264 case though, because we get "...h264" → "...h".

We could just mark GMP crashes in the custom event code and then skip  makeNicePluginName() for them in browser-plugins.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Moving this out of bug 1043531 because it doesn't block QA for that bug and hence shouldn't block it from landing ASAP.

Comment 2

[Marco Mucci [:MarcoM]]

Hi Georg, would you like this added to Iteration 34.1?

Comment 3

[Georg Fritzsche [:gfritzsche]]

Yes, looking into it today.

Comment 4

[Georg Fritzsche [:gfritzsche]]

Attachment: Mark up GMP crash events

Comment 5

[Georg Fritzsche [:gfritzsche]]

Attachment: Skip makeNicePluginname for GMP plugins

Comment 6

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56cc07922391
https://hg.mozilla.org/integration/mozilla-inbound/rev/efa72f3380cf

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/56cc07922391
https://hg.mozilla.org/mozilla-central/rev/efa72f3380cf

Comment 8

[Marco Mucci [:MarcoM]]

Hi Liz, can a QA contact be assigned for verification of this bug.

Comment 9

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Assigning to Anthony since this blocks bug 1043531.

Comment 10

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8463912 [details] [diff] [review]
Mark up GMP crash events

Approval Request Comment
[Feature/regressing bug #]: OpenH264 crash reporting, frontend.
[User impact if declined]: Cut-off plugin name (e.g. "gmpopenh" instead of "gmpopenh264").
[Describe test coverage new/current, TBPL]: Manually tested, automated tested pending other bugs.
[Risks and why]: Low-risk, 2 small changes: one that just marks an event as GMP specific and another that skips processing the name if that marker is set.
[String/UUID change made/needed]: None.

Comment 11

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8463913 [details] [diff] [review]
Skip makeNicePluginname for GMP plugins

Approval Request Comment

See above.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f6c2062afda0
https://hg.mozilla.org/releases/mozilla-aurora/rev/82a8d3181fa9

Comment 13

[Marco Mucci [:MarcoM]]

Hi Georg, Florin has asked for details on how to verify this bug.  Can you provide him with that.

Comment 14

[Georg Fritzsche [:gfritzsche]]

Steps will be up on bug 1043531 in a bit, this bug only fixes the name being cut off there.

Comment 15

[Ada [:adalucinet]]

Verified as fixed with Aurora 33.0a2 (Build ID: 20140731004002) and Nightly 34.0a1 (Build ID: 20140731030206) builds on Windows 7 x64, Mac OS X 10.9.4 and Ubuntu 13.04 64bit - the plugin name is no longer cut off in crash reporter notification.