Closed
Bug 1045515
Opened 11 years ago
Closed 11 years ago
Always highlight missed calls in call log
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Firefox OS Graveyard
Gaia::Dialer
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S2 (15aug)
| Tracking | Status | |
|---|---|---|
| b2g-v2.1 | --- | fixed |
People
(Reporter: rik, Assigned: davidg)
References
Details
(Whiteboard: [planned-sprint c=1])
Attachments
(1 file)
Missed calls should always be highlighted.
This will be mostly code removal.
|
Reporter | |
Updated•11 years ago
|
Target Milestone: --- → 2.1 S2 (15aug)
|
||
Updated•11 years ago
|
Assignee: nobody → david.garciaparedes
Whiteboard: [planned-sprint c=1]
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8468406 -
Flags: review?(anthony)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8468406 [details] [review]
github PR
Redirecting to Doug.
From a quick look, I'm wondering if we could get rid of some images or some more CSS selectors.
Attachment #8468406 -
Flags: review?(anthony) → review?(drs+bugzilla)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8468406 [details] [review]
github PR
See PR.
Attachment #8468406 -
Flags: review?(drs+bugzilla) → review-
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8468406 [details] [review]
github PR
Removed !important
Removed unnecessary CSS rules
Removed unnecessary image files
Attachment #8468406 -
Flags: review- → review?(drs+bugzilla)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8468406 [details] [review]
github PR
I'm not a fan of the red text for the time, especially when I try it on a device. But I'll argue that in bug 1045515.
Attachment #8468406 -
Flags: review?(drs+bugzilla) → review+
|
|
||
Comment 6•11 years ago
|
||
The tree is closed, so I can't merge this now. BTW, please set the ASSIGNED status when you start working on something (at least within the dialer).
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
|
Reporter | |
Comment 7•11 years ago
|
||
I was also worried the "always on" would and discussed it with Carrie last week. I think we need to land it to feel how bad it is in dogfooding. Then we can either revert or find a less distracting theme.
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•