1045519 - [Loop] In case the other party terminates the call, I will not get notified with "Call terminated"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[mbarone]

Device: Flame
Loop version: 08b040a

STR
1. Device A make a call to Device B
2. Device A ends the call

ACTUAL RESULT
Device B is not notified with Call terminated. On both device the Loop feedback page is displayed.

EXPECTED RESULT
As per AC (https://bugzilla.mozilla.org/show_bug.cgi?id=1010713), Device B should be notified with "Call terminated"

Comment 1

[Borja Salguero [:borjasalguero]]

Hi Massimo! I can not reproduce this one (for me it's working as expected) in both scenarios:
- Device B ends a previously answered call:
 + Both devices show the 'feedback' screen
- Device B reject the call without answering:
 + No feedback screen is shown and both devices hide the attention screen as expected.

Could you take a look again? Thanks!

Comment 2

[mbarone]

The AC says:

"In case the call is finished by any other reason than the other party manually terminating, if the other party closes his browser or application or the other party loses Internet connection, I will get notified "Call terminated by a unknown reason (or the reason of the termination if it is known). In this case, a redial button will be shown to the user."

Did you see the reason of termination? The devices only show the feedback screen. Also I did't see the redial button.

If the feedback screen is the expected result for any call (finished correctly or with any other reason), then works for me.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Using the latest 2.0 Flame build on the 165 kk base this issue does occur.  When either party terminates the call the other will not receive a call terminated screen.  Only the call originator receives the feedback screen regardless of who terminated the call, the other device does not.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140815143240
Gaia: d889984833025f208cfd3f3c2c37c87940a529dc
Gecko: 6329352ca531b977979451e77e5862af485388b2
Version: 32.0 (2.0) 
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Loop version: 32219a2

Comment 4

[Maria Angeles Oteo (:oteo)]

Call ended tone will should be played and about the correct string, Rafa, we need your feedback about it: "Ended", "Finished"... Up to you! ;)

Comment 5

[Rafael Rebolleda]

"Call ended" :)

Comment 6

[Maria Angeles Oteo (:oteo)]

Bug 1061227 opened to track the design and implementation of the Redial screen

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/114

In case the other party terminates the call, I will get notified with "Call ended" and corresponding ended tone. Both peers will be notified with "Call ended" and the tone. We will leave the redial button thing for bug 1061227.

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Landed at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/2ac24760fefede770576a15760d8b14afba97657

Thanks Borja!

Comment 9

[mbarone]

Device: Flame
Build: v2.0 with kk v180 (gecko-2d2ca12 gaia-7edd3b0)
Loop version: c28eaef

Tested and works fine