Closed Bug 1045521 Opened 10 years ago Closed 9 years ago

[Contacts-FTU] Change the IAC mechanism by a datastore in order to propagate access tokens between FTU and Contacts

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S2 (15aug)

People

(Reporter: jmcf, Assigned: hola)

References

Details

Attachments

(1 file)

Pull request #22405 (WIP)
481 bytes, text/html
jmcf
: review+
jmcf
: feedback+
Details 
Currently FTU sends the FB and other services access tokens using IAC. We would like to change that approach by storing the token on a datastore shared between the two apps.
Target Milestone: --- → 2.1 S2 (15aug)
Assignee: nobody → hola

        Attachment #8466137 -
        Flags: review?(jmcf)

    
  

        Attachment #8466137 -
        Flags: review?(jmcf) → review-

    
  

        Attachment #8466137 -
        Flags: review- → review?(jmcf)

    
    

    
  
Adrian,

The code looks good. Please complete the tests

thanks

    
  

        Attachment #8466137 -
        Flags: review?(jmcf) → feedback+

    
    

    
  
Comment on attachment 8466137 [details]
Pull request #22405 (WIP)

Tests finished and passing.

        Attachment #8466137 -
        Flags: review?(jmcf)

    
    

    
  
Comment on attachment 8466137 [details]
Pull request #22405 (WIP)

the tests need to be cleaned and some design issues fixed

        Attachment #8466137 -
        Flags: review?(jmcf) → review-

    
    

    
  
Comment on attachment 8466137 [details]
Pull request #22405 (WIP)

Errors solved and tests improved according to comments.

        Attachment #8466137 -
        Flags: review- → review?(jmcf)

    
    

    
  
Comment on attachment 8466137 [details]
Pull request #22405 (WIP)

thanks Adrian

        Attachment #8466137 -
        Flags: review?(jmcf) → review+

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/87244542ce7ed6871137ea7a312b72ae5d037961
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 1053477

          You need to log in
          before you can comment on or make changes to this bug.