1045533 - Firefox OS Simulator on Windows needs sandboxbroker.dll

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Simulator, defect)

Description

[Wander Lairson Costa]

Attachment: WebIDE error screenshot

When I try from app-manager, I get this error message:

07:09:43: connecting to localhost:49367
07:10:03: connection timeout. Possible causes: didn't click on 'accept' (prompt).
07:10:03: disconnecting
07:10:03: disconnected

Comment 1

[Wander Lairson Costa]

Attachment 8463892 [details] contains the screenshot of the error message from WebIDE.

Comment 2

[Paul Rouget [:paul]]

Does the simulator show up?

Do you see any errors in the browser console?

To open the Browser Console, select "Browser Console" from the Web Developer submenu in the Firefox Menu (or Tools menu if you display the menu bar or are on Mac OS X).

Comment 3

[Wander Lairson Costa]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #2)
> Does the simulator show up?
> 
> Do you see any errors in the browser console?
> 
> To open the Browser Console, select "Browser Console" from the Web Developer
> submenu in the Firefox Menu (or Tools menu if you display the menu bar or
> are on Mac OS X).

No, it shows nothing.

Comment 4

[Paul Rouget [:paul]]

What about the browser console output?

Comment 5

[Paul Rouget [:paul]]

Oh, you meant you see nothing in the browser console?

And the simulator doesn't show up at all?

Comment 6

[Wander Lairson Costa]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #5)
> Oh, you meant you see nothing in the browser console?
> 

Yes, nothing show in the console.

> And the simulator doesn't show up at all?

No, it doesn't.

Comment 7

[Paul Rouget [:paul]]

What version of Windows do you use? Windows 7 64 bits?

Comment 8

[Wander Lairson Costa]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #7)
> What version of Windows do you use? Windows 7 64 bits?

Yes, and Firefox 34a1.

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

What's the exact build of the Simulator addon from the Add-on Manager?  It should be a version number with 3 parts, including a date in the last part.

Comment 10

[Wander Lairson Costa]

(In reply to J. Ryan Stinnett [:jryans] from comment #9)
> What's the exact build of the Simulator addon from the Add-on Manager?  It
> should be a version number with 3 parts, including a date in the last part.

I tried both 2.0 and 2.1 simulators:

2.0.20140724
2.1.20140724

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Okay, I can reproduce the issue.  Working on a bisect to figure out where things broke.

Thanks for the report!

Comment 12

[Paul Rouget [:paul]]

(In reply to J. Ryan Stinnett [:jryans] from comment #11)
> Okay, I can reproduce the issue.  Working on a bisect to figure out where
> things broke.
> 
> Thanks for the report!

So I guess this happened when we released the new 2.* builds, right?
Anything we could do to avoid such breakage in the future?

Comment 13

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Wander Lairson Costa from comment #10)
> (In reply to J. Ryan Stinnett [:jryans] from comment #9)
> > What's the exact build of the Simulator addon from the Add-on Manager?  It
> > should be a version number with 3 parts, including a date in the last part.
> 
> I tried both 2.0 and 2.1 simulators:
> 
> 2.0.20140724
> 2.1.20140724

Wander, can you please try the 2.0 simulator again with a fresh launch of Firefox where you do not attempt to use the 2.1 simulator at all?

While I am able to reproduce 2.1.20140724 as broken, the 2.0 simulator currently works fine for me.

Comment 14

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #12)
> (In reply to J. Ryan Stinnett [:jryans] from comment #11)
> > Okay, I can reproduce the issue.  Working on a bisect to figure out where
> > things broke.
> > 
> > Thanks for the report!
> 
> So I guess this happened when we released the new 2.* builds, right?
> Anything we could do to avoid such breakage in the future?

It's a little too early to say for sure, as I'm still working through the root cause...

So far, it doesn't appear to an issue with the actual fixes I landed in the new simulator builds.  I tested each of those on try before they landed.  It seems something else (current suspect is bug 985252) landed around the same time, causing a new issue for the simulator, only on Windows.

I think the best thing we can do in the future is just to be sure to manually test the exact build released, which I skipped after having tested the try builds of my fixes, since it seemed redundant.

I don't think it makes sense to add more automated testing of the current simulator, since we'll be switching to a Mulet-based build in the near future.

Comment 15

[Wander Lairson Costa]

(In reply to J. Ryan Stinnett [:jryans] from comment #13)
> (In reply to Wander Lairson Costa from comment #10)
> > (In reply to J. Ryan Stinnett [:jryans] from comment #9)
> > > What's the exact build of the Simulator addon from the Add-on Manager?  It
> > > should be a version number with 3 parts, including a date in the last part.
> > 
> > I tried both 2.0 and 2.1 simulators:
> > 
> > 2.0.20140724
> > 2.1.20140724
> 
> Wander, can you please try the 2.0 simulator again with a fresh launch of
> Firefox where you do not attempt to use the 2.1 simulator at all?
> 
> While I am able to reproduce 2.1.20140724 as broken, the 2.0 simulator
> currently works fine for me.

Indeed 2.0 works. 2.1 doesn't work both from AppManager and WebIDE, but it breaks 2.0 only when I try 2.1 from WebIDE.

Comment 16

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Wander Lairson Costa from comment #15)
> Indeed 2.0 works. 2.1 doesn't work both from AppManager and WebIDE, but it
> breaks 2.0 only when I try 2.1 from WebIDE.

Okay, glad to hear we're observing the same behavior.  Thanks!

Comment 17

[Paul Rouget [:paul]]

How is that possible? They don't share the same profile, right?

Comment 18

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #17)
> How is that possible? They don't share the same profile, right?

I believe the part about 2.1 breaking 2.0 in WebIDE is related to WebIDE connection or simulator startup error handling.  That part is not something I can always reproduce, but it's separate from the core simulator issue here that prevents the simulator for running at all.

I'll file a new bug for this if I get a good STR for it.

Comment 19

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Add sandboxbroker to b2g desktop

Tim, the sandboxing changes you made in bug 985252 are also run on b2g desktop for Windows.

Currently, b2g desktop fails to startup because we weren't packaging sandboxbroker.dll for that application.

We appear to not currently run tests with b2g desktop on Windows (only builds), so it would have been tricky to catch this ahead of time.

Try: https://tbpl.mozilla.org/?tree=Try&rev=0a7d8c942b2f

Comment 20

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 8464730 [details] [diff] [review]
Add sandboxbroker to b2g desktop

Review of attachment 8464730 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the breakage!

Comment 21

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I've confirmed the build from try works correctly.

Comment 22

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Wander, can you try updating the 2.1 simulator from the add-on manager?  You should get an update to 2.1.20140730, which should now be working.

Comment 23

[Wander Lairson Costa]

(In reply to J. Ryan Stinnett [:jryans] from comment #22)
> Wander, can you try updating the 2.1 simulator from the add-on manager?  You
> should get an update to 2.1.20140730, which should now be working.

It works now, thanks :)

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/eb603baf5af8

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eb603baf5af8

Comment 26

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I've verified this fixed the release simulator.