1045743 - Add support for the Promise<> syntax in Web IDL bindings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Add support for the Promise<type> syntax to Web IDL bindings

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8464404 [details] [diff] [review]
Add support for the Promise<type> syntax to Web IDL bindings

>--- a/dom/webidl/BluetoothDevice2.webidl
>+++ b/dom/webidl/BluetoothDevice2.webidl
>@@ -36,10 +36,10 @@ interface BluetoothDevice : EventTarget
>   // Promise<sequence<DOMString>>
>   [NewObject, Throws]
>-  Promise                                   fetchUuids();
>+  Promise<sequence<DOMString>>              fetchUuids();

Forgot to remove the comment?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Forgot to remove the comment?

Er, yes.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to tip

As expected, this bitrots every day.  :(

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8465389 [details] [diff] [review]
Updated to tip

Review of attachment 8465389 [details] [diff] [review]:
-----------------------------------------------------------------

Is there a plan to make this more than just self-documenting IDL?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Not so far, though if people come up with a clever way to use this, so much the better.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/4685bb81ef6d

Comment 8

[Boris Zbarsky [:bzbarsky]]

> Not so far, though if people come up with a clever way to use this, so much the better.

Er, I lie of course!  I'm using this in bug 1017988 to make sure that a method exposed in global X does not return a Promise<Foo> where Foo is not exposed in global X.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4685bb81ef6d

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4685bb81ef6d