1045746 - Awesome bar suggestions interfere with text entry

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Jim Blandy :jimb]

In Aurora 33.0a2 dated 2014-07-29, awesome bar completion causes typing a second letter to delete the first letter entered. The attached link is for a video that shows what's going on.

In case the video isn't visible:

- I tap in the awesome bar, to begin entering a search term. My page disappears, and I see the "top sites" list and the on-screen keyboard, which is as expected.

- I type "a", and "amazon.com/" appears in the awesome bar. "mazon.com" is selected in blue, and the "/" is selected in amber.

- I type "m", and all the text in the awesome bar, including the "a" I first typed, is replaced by an "m", with no selection and the insertion point sitting after the m.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

What keyboard are you using?

Comment 2

[Jim Blandy :jimb]

My settings says "HTC Sense Input". It's the stock keyboard that came with my phone.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

It appears the HTC keyboard does URL autocompletion on top of Fennec's URL autocompletion, and the conflict breaks things altogether.

Rather than trying to blacklist HTC or putting on a bandaid fix, I think it makes more sense to have an option to disable URL autocompletion in the settings? We've had requests for this setting before. What do you think, Wes?

Comment 4

[Jim Blandy :jimb]

(In reply to Jim Chen [:jchen :nchen] from comment #3)
> It appears the HTC keyboard does URL autocompletion on top of Fennec's URL
> autocompletion, and the conflict breaks things altogether.
> 
> Rather than trying to blacklist HTC or putting on a bandaid fix, I think it
> makes more sense to have an option to disable URL autocompletion in the
> settings? We've had requests for this setting before. What do you think, Wes?

Couldn't we just tell Android that that's not a URL field, since we do our own URL handling?

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Jim Blandy :jimb from comment #4)
> (In reply to Jim Chen [:jchen :nchen] from comment #3)
> > It appears the HTC keyboard does URL autocompletion on top of Fennec's URL
> > autocompletion, and the conflict breaks things altogether.
> > 
> > Rather than trying to blacklist HTC or putting on a bandaid fix, I think it
> > makes more sense to have an option to disable URL autocompletion in the
> > settings? We've had requests for this setting before. What do you think, Wes?
> 
> Couldn't we just tell Android that that's not a URL field, since we do our
> own URL handling?

Last time we looked into it. A lot of keyboards show additional keys like ".com" when we tell them it's a URL field, and users are used to those keys.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

I guess we can try turning off URL mode for HTC keyboards specifically.

Comment 7

[Wesley Johnston (:wesj)]

Sorry for the delay. I don't mind a setting for this. I doubt the people affected would find it though, but at least it would give us something to advise them on. Hooking up browser.urlbar.autocomplete.enabled and then advising people to use about:config would probably have just as much effect.

TBH, I'd prefer to just maintain a blacklist of keyboards to turn this off for than to try and use hacks to fix it.

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Hey Jim, do you mind checking these two Nightly builds and see if either one fixes the bug?

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-1ccd8ec397c8/try-android/fennec-34.0a1.en-US.android-arm.apk

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-89c35388f44b/try-android/fennec-34.0a1.en-US.android-arm.apk

Comment 9

[Aaron Train [:aaronmt]]

http://www.reddit.com/r/firefox/comments/2dby7s/firefox_mobile_i_press_f_in_the_address_bar_and/

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

JimB - Can you test these?

Comment 11

[Jim Blandy :jimb]

Jim Chen posted two new binaries:
http://people.mozilla.org/~nchen/builds/bug1045746-1-fennec-nchen-35.0a1.apk
http://people.mozilla.org/~nchen/builds/bug1045746-2-fennec-nchen-35.0a1.apk

Both of these fix the problem.

Comment 12

[Jim Blandy :jimb]

The bug is also fixed in nightly.