1045757 - Status bar / rocketbar visual regression

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/8abddb42a444dd165332e6642133932a04020b50 cause small regressions on the display of the statusbar and rocketbar

Comment 1

[Dale Harvey (:daleharvey)]

Taking some screenshots

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: rocketbar

This should be in the same position as on the homescreen

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: statusbar

The statusbar is lighter than it should be

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

[Blocking Requested - why for this release]: The regression was landed in bug 1038988, and it looks quite unprofessional. My hope is to have a patch for this today.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

In commit [1], we hide the statusbar background for the homescreen. This makes my opacity change not work. Fortunately, this was not uplifted to 2.0. I'm checking now on 2.0 if the rocketbar search position is effected on 2.0. If not, we don't need to uplift this bug.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

This issue doesn't occur on 2.0 with my patch applied. It's from the conflict between [1] from bug 1043272, which will not be uplifted. Clearing blocking flag.

1.) https://github.com/mozilla-b2g/gaia/commit/500ebd79331a50f67e59e4aa0d6dc23af2e5387a#diff-19076406e0c835797eb201e0143532c7L24

Comment 7

[Jason Smith [:jsmith]]

Do we need this fixed on 2.1 instead, since that patch is present on 2.1?

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Jason Smith [:jsmith] - At Work Week, Slow to Respond from comment #7)
> Do we need this fixed on 2.1 instead, since that patch is present on 2.1?

We will once bug 1038988 lands again, yes.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Let's close this, since bug 1038988 will need rework before land, and we will make sure we don't see this same visual regression there.