1045828 - [B2G][Everything.me] No option to add E.me apps to the Homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Josh Schmitt [Joshs]]

Attachment: log.txt

Description:
In E.me apps, there is no option for the user to add the app to the homescreen.

Repro Steps:
1) Update a Flame to 20140729040211
2) Select the E.me search bar
3) Type Social in the search
4) Select Facebook

Actual:
There is no option for the user to add the app to the Homescreen and the user is unable to add E.me apps to the Homescreen.

Expected:
The bottom bar appears and user is able to select the Star icon to access the 'add to homescreen' page.

Environmental Variables:
Device: Flame Master
Build ID: 20140729040211
Gaia: fadfafa17f5175203b8b9457bfb95e5816f54f58
Gecko: b17cad2d1e5e
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Notes:
Repro frequency: 100%
See attached: https://www.youtube.com/watch?v=SrOiMxp4Fb4 and logcat

Comment 1

[Josh Schmitt [Joshs]]

Issue does not occur on 2.0

Environmental Variables:
Device: Flame 2.0
Build ID: 20140729000201
Gaia: b11775fcbfe076a3fc560c2041f5b2fe1b345009
Gecko: 86b56e101512
Version: 32.0 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Regression, smoke test blocker.

Requesting a window.

Comment 3

[Chris Kreinbring [:CKreinbring]]

Regression window
Last working
Build ID: 20140728114105
Gaia: 295967a0b824a355ae9d57fb08f3632ed2ad18dd
Gecko: 9df0fa90ab34
Platform Version: 34.0a1
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First broken
Build ID: 20140728123640
Gaia: fadfafa17f5175203b8b9457bfb95e5816f54f58
Gecko: 75fe3b8f592c
Platform Version: 34.0a1
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Working Gaia / Broken Gecko = No repro
Gaia: 295967a0b824a355ae9d57fb08f3632ed2ad18dd
Gecko: 75fe3b8f592c
Broken Gaia / Working Gecko = Repro
Gaia: fadfafa17f5175203b8b9457bfb95e5816f54f58
Gecko: 9df0fa90ab34
Gaia push log: https://github.com/mozilla-b2g/gaia/compare/295967a0b824a355ae9d57fb08f3632ed2ad18dd...fadfafa17f5175203b8b9457bfb95e5816f54f58

B2G-inbound
Last working
Build ID: 20140728052714
Gaia: d9afe81149d83ce34fbb68769c5820415580f6f7
Gecko: 0e48db820d99
Platform Version: 34.0a1
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First broken
Build ID: 20140728054813
Gaia: 3357c45e793bfca7648d215f378eb47e4e97aa23
Gecko: 0564c0d5a1bb
Platform Version: 34.0a1
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Working Gaia / Broken Gecko = No repro
Gaia: d9afe81149d83ce34fbb68769c5820415580f6f7
Gecko: 0564c0d5a1bb
Broken Gaia / Working Gecko = Repro
Gaia: 3357c45e793bfca7648d215f378eb47e4e97aa23
Gecko: 0e48db820d99
Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/d9afe81149d83ce34fbb68769c5820415580f6f7...3357c45e793bfca7648d215f378eb47e4e97aa23

Comment 4

[Joshua Mitchell (Inactive)]

Possibly broken by bug 1042744 - Vivien can you take a look?

Comment 5

[Kevin Grandon :kgrandon]

This is being added to the overflow menu soon, I might take a look. We need tests for this.

Comment 6

[Kevin Grandon :kgrandon]

Chris - this is a smoketest blocker that we've introduced by removing the old browser chrome. The new browser chrome includes the overflow menu which has an option to add to the homescreen.

I suggest we get QA unblocked as quickly as possible by implementing only the "Add to home screen" option either in place of the menu, or as the only option when triggered.

Do you think this is something you could look at and knock out quickly?

Comment 7

[Chris Lord [:cwiiis]]

(In reply to Kevin Grandon :kgrandon from comment #6)
> Chris - this is a smoketest blocker that we've introduced by removing the
> old browser chrome. The new browser chrome includes the overflow menu which
> has an option to add to the homescreen.
> 
> I suggest we get QA unblocked as quickly as possible by implementing only
> the "Add to home screen" option either in place of the menu, or as the only
> option when triggered.
> 
> Do you think this is something you could look at and knock out quickly?

Looking at this now.

Comment 8

[Chris Lord [:cwiiis]]

Attachment: Implement browser overflow menu with a single 'add to home' option for now

Initial implementation of the overflow menu according to spec, but missing all options except add-to-home-screen.

Comment 9

[Chris Lord [:cwiiis]]

Comment on attachment 8466652 [details] [review]
Implement browser overflow menu with  a single 'add to home' option for now

Vivien would also be a good reviewer for this.

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8466652 [details] [review]
Implement browser overflow menu with  a single 'add to home' option for now

I think this is great - nice first step, gets QA unblocked. We will need to update it to work with web content as well, but we can do that later.

For this you probably should wait for Vivien's review as well since I'm not a system peer.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8466652 [details] [review]
Implement browser overflow menu with  a single 'add to home' option for now

Very close but I would like to see an updated patch.

The 2 big questions I have are:
 - Should we load the overflow menu content lazily ?
 - Should it cover the urlbar / statusbar or should we moved it into the scrollable part ?

Comment 12

[Kevin Grandon :kgrandon]

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #11)
>  - Should it cover the urlbar / statusbar or should we moved it into the
> scrollable part ?


Which part needs to cover? AFAIK "overflow menu" is an old term, now it's just the menu that has a trigger to the right of the rocketbar.

Comment 13

[Chris Lord [:cwiiis]]

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #11)
> Comment on attachment 8466652 [details] [review]
> Implement browser overflow menu with  a single 'add to home' option for now
> 
> Very close but I would like to see an updated patch.
> 
> The 2 big questions I have are:
>  - Should we load the overflow menu content lazily ?

Sure, will do this Monday.

>  - Should it cover the urlbar / statusbar or should we moved it into the
> scrollable part ?

No, this is not what the spec lays out:
https://mozilla.box.com/s/urudcnxj6ub4ov95ltx7
https://mozilla.box.com/s/r36n5hqu8ji0rppo2e1j

Comment 14

[Chris Lord [:cwiiis]]

Comment on attachment 8466652 [details] [review]
Implement browser overflow menu with  a single 'add to home' option for now

Updated with lazy-loading of overflow menu.

Comment 15

[Chris Lord [:cwiiis]]

And just updated with all the review comments I missed because I forget that we do reviews on github and not bugzilla :)

Comment 16

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8466652 [details] [review]
Implement browser overflow menu with  a single 'add to home' option for now

LGTM.

Comment 17

[Chris Lord [:cwiiis]]

Merged: https://github.com/mozilla-b2g/gaia/commit/d53b9704df340760441375e999d6d85d8e08a0f0

Comment 18

[Tony Chung [:tchung]]

Josh, please retest this on tomorrow's master build and verify if its fixed.  Thx.

Comment 19

[Kevin Grandon :kgrandon]

(In reply to Tony Chung [:tchung] from comment #18)
> Josh, please retest this on tomorrow's master build and verify if its fixed.
> Thx.

Also please note that the location of this button has changed and is aligned with the new rocketbar spec. The link can now be found my clicking on the menu icon to the right of the URL bar. Please let us know if you have any questions. Thanks!

Comment 20

[Josh Schmitt [Joshs]]

I am unable to verify this bug currently because when I try the STR's from comment 19 the button does not work, nothing is selected when I press the ellipsis that located on the right side of the URL bar.

Are changes still landing or should I file a new bug?

Environmental Variables:
Device: Flame Master 319MB
Build ID: 20140805040204
Gaia: 19bf9795263e2ccc15d824a52ebf23c2670fa9b9
Gecko: 7f81be7db528
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 21

[Kevin Grandon :kgrandon]

Are you sure you have the patch? It looks like the gaia revision you listed in comment 20 (19bf9795263e2ccc15d824a52ebf23c2670fa9b9) was landed before this PR landed? 

Which result are you trying to bookmark? Everything should be in master, and I am able to bookmark results.

Comment 22

[Josh Schmitt [Joshs]]

(In reply to Kevin Grandon :kgrandon from comment #21)
> Are you sure you have the patch? It looks like the gaia revision you listed
> in comment 20 (19bf9795263e2ccc15d824a52ebf23c2670fa9b9) was landed before
> this PR landed? 
> 
> Which result are you trying to bookmark? Everything should be in master, and
> I am able to bookmark results.

I am going to retest with the latest gaia.

Comment 23

[Josh Schmitt [Joshs]]

After retesting this issue, the bug does NOT occur on the latest gaia.

Will retest on tomorrows nightly build.

Environmental Variables:
Device: Flame Master 319MB
Build ID: 20140805040204
Gaia: f1fa5921f31bbe3ab5b19f972fd444ad7c264fa8
Gecko: 7f81be7db528
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 24

[Josh Schmitt [Joshs]]

Verified fixed on the latest 2.1 Flame 319MB

Environmental Variables:
Device: Flame Master
Build ID: 20140806040201
Gaia: 88295e1ec6d52bd63d45ea0e3673a3f933f4a6b9
Gecko: 6cbdd4d523a7
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0