Open Bug 1045863 Opened 10 years ago Updated 2 years ago

try to combine two branches in nsStyleContext::CalcStyleDifference

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

People

(Reporter: heycam, Unassigned)

References

(Blocks 1 open bug)

Details

After bug 931668 lands, we should try to combine these two branches inside the macro in nsStyleContext::CalcStyleDifference:

      } else if (compare ||
                 (NS_SubtractHint(maxDifference,
                                  maxDifferenceNeverInherited) &
                  aParentHintsNotHandledForDescendants)) {
        ...
      } else {
        /* We still must call CalcDifference to see if there were any */
        /* changes so that we can set *aEqualStructs appropriately.   */
        ...
      }

We should just be able to call CalcDifference on each struct and not try to optimise things by checking |compare| and maxDifference and aParentHintsNotHandledForDescendants.  Doing so currently results in test failures though.
Blocks: 1045868
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.