1045922 - [email] quick tap on message in list after first load sometimes does not work

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[James Burke [:jrburke]]

With the cookie cache, it is possible to tap on an email message to start navigating to the message_reader card even before the full data model is loaded up.

With the outbox changes (only on master, not on 2.0), it introduced a failure in message_list's onClickMessage where it expects this.curFolder to already be set.

The error only occurs if you tap fast enough, and it is non-fatal. If you try again a bit later everything still works. The only evidence of the error is watching the logcat, and this will show up:

ERR: onerror reporting: TypeError: this.curFolder is null @ app://email.gaiamobile.org/js/mail_app.js : 2458

It is a simple fix to only do that check if there is a curFolder, prepping a fix now.

Comment 1

[James Burke [:jrburke]]

Attachment: GitHub pull request

Just a test for this.curFolder for a fix. Asking :mcav since he has outbox context.

Comment 2

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8464332 [details] [review]
GitHub pull request

Looks good, thanks for catching that.

Comment 3

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/c6a6ac54703970ad4668d37161f599d438e37681

from pull request:
https://github.com/mozilla-b2g/gaia/pull/22281

Comment 4

[Edward Chen[:edchen]]

[Environment]
Gaia      3584b2723412ed3299c6761f465885d80651c87e
Gecko     https://hg.mozilla.org/mozilla-central/rev/e7806c9c83f3
BuildID   20140820160201
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014


[Result]
PASS