Closed Bug 1045978 Opened 5 years ago Closed 5 years ago

Create InternalSVGZoomEvent and InternalSMILTimeEvent for NS_SVGZOOM_EVENT and NS_SMIL_TIME_EVENT

Categories

(Core :: User events and focus handling, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

NS_SVGZOOM_EVENT and NS_SMIL_TIME_EVENT are hacky. They are used with WidgetGUIEvent and InternalUIEvent. However, for simpler rule and consistency with other event classes, they should have individual classes.
Attached patch PatchSplinter Review
This patch allows nsEventStructType will be generated with macro of EventClassList.h.
Attachment #8464658 - Flags: review?(bugs)
Comment on attachment 8464658 [details] [diff] [review]
Patch

huh, this svg event code is, well was, crazy.
Thanks!

(Not sure if those mBubbles and mCancelable should be in the ctors, but since they are current in the
DOM event ctors, fine.)
Attachment #8464658 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/917b5e49c7f4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.