Closed
Bug 1045978
Opened 10 years ago
Closed 10 years ago
Create InternalSVGZoomEvent and InternalSMILTimeEvent for NS_SVGZOOM_EVENT and NS_SMIL_TIME_EVENT
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
|
18.83 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
NS_SVGZOOM_EVENT and NS_SMIL_TIME_EVENT are hacky. They are used with WidgetGUIEvent and InternalUIEvent. However, for simpler rule and consistency with other event classes, they should have individual classes.
|
Assignee | |
Comment 1•10 years ago
|
||
This patch allows nsEventStructType will be generated with macro of EventClassList.h.
Attachment #8464658 -
Flags: review?(bugs)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8464658 [details] [diff] [review]
Patch
huh, this svg event code is, well was, crazy.
Thanks!
(Not sure if those mBubbles and mCancelable should be in the ctors, but since they are current in the
DOM event ctors, fine.)
Attachment #8464658 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
OS: Windows 8.1 → All
Hardware: x86_64 → All
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•