104599 - crash in nsPluginHostImpl::InstantiateEmbededPlugin @ line 3236 - N70PR1 [@ nppl3260.dll - nsPluginHostImpl::InstantiateEmbededPlugin]

Status: RESOLVED WORKSFORME

(Plugins Graveyard :: RealPlayer (Real), defect, P4)

Description

[Peter Lubczynski]

While looking at talkback, I saw a strange crash in npplgh3260.dll in incident
36476481. I don't know what plugin this is so I can't reproduce! Shrir reported
it at 2001-10-09 13:29:16 but didn't leave any comments. However, talkback says
the problem is happening on line 3236 of nsPluginHostImpl.cpp. Looking at the
source, it is VERY likely the following line is dereferencing a null pointer! It
looks like a programing oversight. Attaching a simple null-pointer check patch.

Comment 1

[Peter Lubczynski]

Attachment: stack

Comment 2

[Peter Lubczynski]

Attachment: null-pointer check patch

Comment 3

[Peter Lubczynski]

actually, this needs more investigation....

GetWindow() always returns a pointer to a member variable so it won't be null.
And the crash actually has two calls inside the plugin which leads me to think
that it may not even be our fault. Without a testcase or even knowing what
plugin it is, can't do much. Futuring for now...

Comment 4

[Jaime Rodriguez, Jr.]

Adding keyword grafitti so it shows up on the radar.

Comment 5

[Peter Lubczynski]

minus, not a stop ship

Comment 6

[Jaime Rodriguez, Jr.]

are we taking a look at this one for MachV?

Comment 7

[Peter Lubczynski]

This crash just happened to me. The crash was inside Real Player, on
|nsIPluginInstance::Start|. The problem was that I had a dis-synced
nppl3260.dll. Reinstalling Real One and ensuring I had the right version of the
DLL in the right locatation saved me from the crash.

Comment 8

[Jay Patel [:jay]]

Adding testcase, topcrash+ keywords and N70PR1 [@ nppl3260.dll -
nsPluginHostImpl::InstantiateEmbededPlugin] to summary for tracking.  This has
been a topcrasher for Netscape 7.0 PR1.

Comment 9

[Shiva Thirumazhusai]

-> topcrash- by Talkback Triage Team.

Comment 10

[rubydoo123]

*** Bug 154434 has been marked as a duplicate of this bug. ***

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

On this page, http://www.mtv.com/music/video/premiere/system_of_a_down/, I can
crash 100% if I click on the link to the 'Aerials' video.

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

Regarding http://bugzilla.mozilla.org/show_bug.cgi?id=104599#c7 - what end-user
is going to do that?  Using our default install of Netscape 7, I crash trying to
view _any_ embedded Real content.  That can't be good.  I'd like to propose that
we try to fix this for RTM.

Comment 13

[Peter Lubczynski]

Where any updates to Real installed?

Does reinstalling Netscape 7 make Real work?

What version of Real are you running? The Netscape 7 installer should take care
of doing comment #7 for the end user but I wonder what caused this crash to start?

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

This is odd - it works again, all of a sudden (just after installing today's
commercial branch build on Windows 2000).  

Comment 15

[Jaime Rodriguez, Jr.]

sounds like a wfm candidate.

Comment 16

[Peter Lubczynski]

Well, like I said, the Netscape 7 installer seems to "fix" things for this stack
signature but the user would need to somehow know to re-run it. Should this be
release or tech noted that a reinstall of the browser may solve crashes on Real?

Comment 17

[Peter Lubczynski]

*** Bug 160427 has been marked as a duplicate of this bug. ***