Closed Bug 1046079 Opened 11 years ago Closed 11 years ago

Exception running bootstrap method uninstall on firefox-hotfix@mozilla.org: TypeError: this._s is null

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Iteration:
34.2

People

(Reporter: gfritzsche, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Don't error if this._s is undefined
1.80 KB, patch
benjamin
: review+
Details | Diff | Splinter Review
I've encountered this running on todays mozilla-aurora state: 1406718478713 addons.xpi WARN Exception running bootstrap method uninstall on firefox-hotfix@mozilla.org: TypeError: this._s is null (resource://firefox-hotfix/update.jsm:667:8) JS Stack trace: UpgradeManager.prototype._cleanup@update.jsm:667:9 < UpgradeManager.prototype.addonManagerUninstall@update.jsm:738:5 < uninstall@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///Users/gfritzsche/Library/Application%20Support/Firefox/Profiles/nv3njqwb.dev3/extensions/firefox-hotfix@bootstrap.js:80:5 < XPI_callBootstrapMethod@XPIProvider.jsm:4303:9 < XPI_uninstallAddon@XPIProvider.jsm:4541:1 < AddonWrapper_uninstall@XPIProvider.jsm:6775:5 < install/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///Users/gfritzsche/Library/Application%20Support/Firefox/Profiles/nv3njqwb.dev3/extensions/firefox-hotfix@bootstrap.js:42:7 < safeCall@AddonManager.jsm:168:5 < getAddonByID_safeCall@AddonManager.jsm:1936:13 < getAddonByID_getVisibleAddonForID@XPIProvider.jsm:3675:7 < makeSafe/<@XPIProviderUtils.js:146:17 < completeAddon@XPIProviderUtils.js:135:5 < getAddon@AddonRepository.jsm:585:7 < this.AddonRepository.getCachedAddonByID<@AddonRepository.jsm:617:5 < TaskImpl_run@Task.jsm:314:40 < TaskImpl@Task.jsm:275:3 < createAsyncFunction/asyncFunction@Task.jsm:249:14 < getRepositoryAddon@XPIProviderUtils.js:137:3 < this.XPIDatabase.getAddon/<@XPIProviderUtils.js:1091:9 < Handler.prototype.process@Promise-backend.js:866:23 < this.PromiseWalker.walkerLoop@Promise-backend.js:745:7 < openModalWindow@nsPrompter.js:369:5 < ModalPrompter.prototype.openPrompt@nsPrompter.js:552:9 < ModalPrompter.prototype.confirmEx@nsPrompter.js:696:9 < Prompter.prototype.confirmEx@nsPrompter.js:78:16 < BG__onWindowsRestored/<@nsBrowserGlue.js:736:20 Might be due to local build or switching with the same profile between channels etc., so close if you think it's not relevant to the real population.
I seem to recall seeing this error while I was developing the extension. I believe it is due to channel switching. The forensics data indicates this isn't uncommon, so it might be worth fixing this for v2.
To clarify, the forensics data indicates that switching channels isn't uncommon. We don't have data that indicates how often this specific error is occurring.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Flags: firefox-backlog+
Points: --- → 2
Unexpected scenarios could result in _cleanup() getting called before startup was complete and this._s was populated. We now properly handle those scenarios.
Attachment #8468728 - Flags: review?(benjamin)
Attachment #8468728 - Flags: review?(benjamin) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
QA Whiteboard: [qa-]
Resolution: --- → FIXED
Iteration: --- → 34.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: