Prevent using hardcoded brand names in l10n data files

RESOLVED FIXED in Firefox 34

Status

Hello (Loop)
Client
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mikedeboer, Assigned: alexbardas)

Tracking

unspecified
mozilla34
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox34 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
At the moment, brand names are hardcoded in our l10n data files. We'd probably want to use brandShortname wherever it now says 'Firefox' and clientShortname wherever it now says 'Loop'.
Don't we want clientShortname to be "WebRTC" and later switch to "Hello" ? 

[0] https://bugzilla.mozilla.org/show_bug.cgi?id=1000127#c4
I'm removing "first release needed" because we want this independent of the direct calling and contacts work.
Whiteboard: [qa-][first release needed] → [qa-]
Target Milestone: mozilla34 → 34 Sprint 1- 8/4
(Reporter)

Updated

4 years ago
Status: NEW → ASSIGNED

Updated

4 years ago
Flags: firefox-backlog+
(Reporter)

Comment 3

4 years ago
Un-assigning, because it's unlikely that I'll be working on this before my PTO starts.
Assignee: mdeboer → nobody
Status: ASSIGNED → NEW
Setting this as blocking bug 1000269 as that's when we'll want it before.
Blocks: 1000269
Whiteboard: [qa-] → [p=2, qa-]

Updated

4 years ago
Iteration: 34.1 → ---
Target Milestone: 34 Sprint 1- 8/4 → mozilla34

Updated

4 years ago
Whiteboard: [p=2, qa-] → [qa-]

Updated

4 years ago
Flags: qe-verify-
Whiteboard: [qa-]
(Assignee)

Updated

4 years ago
Assignee: nobody → abardas
Status: NEW → ASSIGNED

Updated

4 years ago
Iteration: --- → 34.3
(Assignee)

Comment 5

4 years ago
Created attachment 8476384 [details] [diff] [review]
Prevent using hardcoded brand names in l10n data files

I didn't find other files dealing with l10n in loop. I've locally tested in both Firefox and Safari (which doesn't support WebRTC).
Attachment #8476384 - Flags: review?(adw)
Comment on attachment 8476384 [details] [diff] [review]
Prevent using hardcoded brand names in l10n data files

This localization note,
> ## LOCALIZATION NOTE (legal_text_and_links): In this item, don't translate the
> ## part between {{..}}
should be moved up since the {{..}} are now found higher up and throughout the document. Maybe just put this above any of the l10n strings.
Attachment #8476384 - Flags: review?(adw) → review+
(Assignee)

Comment 7

4 years ago
Created attachment 8476469 [details] [diff] [review]
bug1046178_loop_prevent_using_hardcoded_brand_names_in_l10n_data_files.diff
Attachment #8476384 - Attachment is obsolete: true
Attachment #8476469 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9a49a2d10b3a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Untracking for QA. Please needinfo me to request specific testing.
Whiteboard: [qa-]
Depends on: 1064173
status-firefox34: --- → fixed
QA Contact: anthony.s.hughes
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.