1046178 - Prevent using hardcoded brand names in l10n data files

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

At the moment, brand names are hardcoded in our l10n data files. We'd probably want to use brandShortname wherever it now says 'Firefox' and clientShortname wherever it now says 'Loop'.

Comment 1

[Andrei Oprea [mention me on [e-mail]]]

Don't we want clientShortname to be "WebRTC" and later switch to "Hello" ? 

[0] https://bugzilla.mozilla.org/show_bug.cgi?id=1000127#c4

Comment 2

[Maire Reavy [:mreavy]]

I'm removing "first release needed" because we want this independent of the direct calling and contacts work.

Comment 3

[Mike de Boer [:mikedeboer]]

Un-assigning, because it's unlikely that I'll be working on this before my PTO starts.

Comment 4

[Mark Banner (:standard8)]

Setting this as blocking bug 1000269 as that's when we'll want it before.

Comment 5

[Alex Bardas :alexbardas]

Attachment: Prevent using hardcoded brand names in l10n data files

I didn't find other files dealing with l10n in loop. I've locally tested in both Firefox and Safari (which doesn't support WebRTC).

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8476384 [details] [diff] [review]
Prevent using hardcoded brand names in l10n data files

This localization note,
> ## LOCALIZATION NOTE (legal_text_and_links): In this item, don't translate the
> ## part between {{..}}
should be moved up since the {{..}} are now found higher up and throughout the document. Maybe just put this above any of the l10n strings.

Comment 7

[Alex Bardas :alexbardas]

Attachment: bug1046178_loop_prevent_using_hardcoded_brand_names_in_l10n_data_files.diff

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a49a2d10b3a

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9a49a2d10b3a

Comment 10

[u279076]

Untracking for QA. Please needinfo me to request specific testing.