Closed Bug 1046178 Opened 10 years ago Closed 10 years ago

Prevent using hardcoded brand names in l10n data files

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
2

Tracking

(firefox34 fixed)

RESOLVED FIXED
mozilla34
Iteration:
34.3
Tracking Status
firefox34 --- fixed

People

(Reporter: mikedeboer, Assigned: alexbardas)

References

Details

Attachments

(1 file, 1 obsolete file)

At the moment, brand names are hardcoded in our l10n data files. We'd probably want to use brandShortname wherever it now says 'Firefox' and clientShortname wherever it now says 'Loop'.
Don't we want clientShortname to be "WebRTC" and later switch to "Hello" ? 

[0] https://bugzilla.mozilla.org/show_bug.cgi?id=1000127#c4
I'm removing "first release needed" because we want this independent of the direct calling and contacts work.
Whiteboard: [qa-][first release needed] → [qa-]
Target Milestone: mozilla34 → 34 Sprint 1- 8/4
Status: NEW → ASSIGNED
Flags: firefox-backlog+
Un-assigning, because it's unlikely that I'll be working on this before my PTO starts.
Assignee: mdeboer → nobody
Status: ASSIGNED → NEW
Setting this as blocking bug 1000269 as that's when we'll want it before.
Blocks: 1000269
Whiteboard: [qa-] → [p=2, qa-]
Iteration: 34.1 → ---
Target Milestone: 34 Sprint 1- 8/4 → mozilla34
Whiteboard: [p=2, qa-] → [qa-]
Flags: qe-verify-
Whiteboard: [qa-]
Assignee: nobody → abardas
Status: NEW → ASSIGNED
Iteration: --- → 34.3
I didn't find other files dealing with l10n in loop. I've locally tested in both Firefox and Safari (which doesn't support WebRTC).
Attachment #8476384 - Flags: review?(adw)
Comment on attachment 8476384 [details] [diff] [review]
Prevent using hardcoded brand names in l10n data files

This localization note,
> ## LOCALIZATION NOTE (legal_text_and_links): In this item, don't translate the
> ## part between {{..}}
should be moved up since the {{..}} are now found higher up and throughout the document. Maybe just put this above any of the l10n strings.
Attachment #8476384 - Flags: review?(adw) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9a49a2d10b3a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Untracking for QA. Please needinfo me to request specific testing.
Whiteboard: [qa-]
Depends on: 1064173
QA Contact: anthony.s.hughes
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.