1046191 - Add MOZ_COUNT_CTOR,DTOR for GMPProcessParent

Status: RESOLVED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Andrew McCreight [:mccr8]]

Right now we seem to only seem to detect leaks like bug 1046165 with LSan, which is a crummy user experience. These all seem rooted in GMPProcessParent, so we should add MOZ_COUNT_CTOR stuff so we detect these leaks in all debug builds.

Comment 1

[Andrew McCreight [:mccr8]]

> which is a crummy user experience
I really meant "which is a crummy Gecko developer experience".

Comment 2

[Andrew McCreight [:mccr8]]

Hrmph, this didn't actually turn the tree orange when landed on top of jld's leak, which is what I would expect:
  https://tbpl.mozilla.org/?tree=Try&rev=644c880e291f

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Andrew McCreight [:mccr8] from comment #2)
> Hrmph, this didn't actually turn the tree orange when landed on top of jld's
> leak, which is what I would expect:
>   https://tbpl.mozilla.org/?tree=Try&rev=644c880e291f

The memory leak (bug 1046539) was provoked by a child process crash, and that crash (bug 1046538) occurred only on Sanitizer builds.

I suggest trying it again with a MOZ_CRASH() somewhere near the PR_LoadLibrary in GMPChild.

Comment 4

[Andrew McCreight [:mccr8]]

Oh, right, I meant to retest that, thanks.

Comment 5

[Andrew McCreight [:mccr8]]

GMPProcessParent inherits from GeckoChildProcessHost which already has MOZ_COUNT_CTOR, so hopefully this just works.  I'm not sure how I missed that before.  So I'm just going to assume this happened due to the broken leak checking infrastructure...