Closed Bug 1046224 Opened 6 years ago Closed 6 years ago

--disable-dtrace unexpectedly enables dtrace

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file)

The code uses AC_ARG_ENABLE but assumes MOZ_ARG_ENABLE_BOOL behavior. This may cause an issue if --enable-dtrace becomes the default or user tries to override the value from parent mozconfig.

AC_ARG_ENABLE(FEATURE, HELP-STRING [, ACTION-IF-GIVEN [, ACTION-IF-NOT-GIVEN]])
MOZ_ARG_ENABLE_BOOL(NAME, HELP, IF-YES [, IF-NO [, ELSE]])

$ ../configure --disable-dtrace
$ fgrep DTRACE config/autoconf.mk
ACDEFINES = ... -DINCLUDE_MOZILLA_DTRACE='1' ...
HAVE_DTRACE = 1
Nothing else in the file uses AC_ARG_ENABLE but alternative fix is to remove [enable_dtrace="yes"] from ACTION-IF-GIVEN.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=9bd2719f5dcb
Attachment #8464814 - Flags: review?(ted)
Attachment #8464814 - Flags: review?(ted) → review+
Assignee: nobody → jbeich
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a8027d413246
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.