1046254 - [B2G][Homescreen] Unable to launch apps after moving them to the bottom row

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Josh Schmitt [Joshs]]

Attachment: log.txt

Description:
After moving any type of app in-between two apps on the last page will make that app not selectable or launchable.

Repro Steps:
1) Update a Flame to 20140730000206
2) Open Marketplace
3) Download and install 5 apps
4) On the Homescreen move any app in-between any two apps on the last page

Actual:
The apps that were moved are no longer selectable or launchable

Expected:
The apps are able to be selected and launched after moving them.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140730000206
Gaia: 2e85678de2c8e13e585288d4cec7d6673cee17ee
Gecko: 6e37ecf873da
Version: 32.0 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Notes:
Repro frequency: 90%
See attached: https://www.youtube.com/watch?v=BGPSAQ-7mfU& and logcat

Comment 1

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Smoke Test blocker of a core function.

Requesting qawanted to find if this was a regression within 2.0. VH wasn't available in 1.4.

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

Issue does NOT reproduce on first vertical homescreen build in central.

Behavior: Apps can be opened as expected after moving between two apps on bottom row.

Device: Flame
Build ID: 20140604173717
Gaia: d2cfef555dabab415085e548ed44c48a99be5c32
Gecko: 2ebadbba6cc8
Version: 32.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

----------

Issue is reproducible on latest 2.1 Flame master and 2.1 Buri.

Observed Behavior: Apps can't be opened after moving between two apps on bottom row.

Device: Flame
Build ID: 20140730045709
Gaia: 25e998814ba89f30fe44cd2fdfbb44d160a04641
Gecko: 08c23f12a43e
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Buri
Build ID: 20140730045709
Gaia: 25e998814ba89f30fe44cd2fdfbb44d160a04641
Gecko: 08c23f12a43e
Version: 34.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 3

[Joshua Mitchell (Inactive)]

This is a regression between first vertical homescreen and later 2.0 builds

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

b2g inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20140717033639
Gaia: a470c523d1f0d50c039f6a7e0326a06e2a4e7db3
Gecko: 36bfce8e7a41
Version: 33.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken Environmental Variables:
Device: Flame
Build ID: 20140717040636
Gaia: fbe6a99c9c16bdd252f27853536268b478014740
Gecko: a7c771511d20
Version: 33.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken gecko & last working gaia - issue does NOT repro
Gaia: a470c523d1f0d50c039f6a7e0326a06e2a4e7db3
Gecko: a7c771511d20

First broken gaia & last working gecko - issue DOES repro
Gaia: fbe6a99c9c16bdd252f27853536268b478014740
Gecko: 36bfce8e7a41

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/a470c523d1f0d50c039f6a7e0326a06e2a4e7db3...fbe6a99c9c16bdd252f27853536268b478014740

Caused by Bug 1037256?

Comment 5

[Gregor Wagner [:gwagner]]

Thanks PiWei!

Seems like a bug for Kevin.

Comment 6

[Kevin Grandon :kgrandon]

I am currently unable to reproduce, but I highly doubt that anything in the homescreen is causing this. My bet is that this is some APZ issue.

We are also going to be landing bug 1043293 soon which could potentially work around the issue, so let's wait and see if that fixes anything.

Comment 7

[Kevin Grandon :kgrandon]

Turns out this may not be related to APZ. I think we have some ghost elements in the DOM. :)

Comment 8

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Turns out we were leaving the placeholders in the grid to cover up icons.

Carmen - since I think you were the author of this, cold you review it by chance? Thanks!

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8465181 [details] [review]
Github pull request

Or Aus - maybe if you have some free cycles could you give this a quick review? Thanks!

Comment 10

[Aus Lacroix [:aus]]

Comment on attachment 8465181 [details] [review]
Github pull request

lgtm!

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8465181 [details] [review]
Github pull request

Thanks for the review Aus!

Comment 12

[[:fabrice] Fabrice Desré]

https://github.com/mozilla-b2g/gaia/commit/65efce8c5ee48c72f296e33679678df5222600f9

Comment 13

[Kevin Grandon :kgrandon]

I will uplift this later.

Comment 14

[Kevin Grandon :kgrandon]

2.0: https://github.com/mozilla-b2g/gaia/commit/8ebc9f906886f6ef7eb2c2596baa085666908b80

Comment 15

[Benjamin Kerensa [:bkerensa]]

FWIW looks fixed on 2.1