Closed Bug 1046336 Opened 7 years ago Closed 7 years ago

(2.1-visual-refresh) System Sound Refresh

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(feature-b2g:2.1)

RESOLVED FIXED
feature-b2g 2.1

People

(Reporter: padamczyk, Assigned: pivanov)

References

Details

Attachments

(2 files)

Replace the v.1 sounds with the v.2 design.
Summary: (2.1-visual-refresh) Sound Refresh → (2.1-visual-refresh) Media Sound Refresh
No longer depends on: NewSounds-2.1
Component: Gaia::Camera → Gaia::System
Summary: (2.1-visual-refresh) Media Sound Refresh → (2.1-visual-refresh) System Sound Refresh
Patryk,

Where are with this? Don't see any updates on this bug. Have we landed everything required for 2.1 w.r.t to new sounds?

Sprint 3 ends tomorrow 8/29
Flags: needinfo?(padamczyk)
No longer blocks: NewSounds-2.1
Flags: needinfo?(padamczyk)
Attached file system.zip
Attached are 3 improved system sounds:
+ homescreen: unlock
+ keyboard keys

Kevin can we still get these into 2.1, I believe the risk is really low. 
+ 3 sound files swapped out
+ ogg file extension renamed to opus

If not can we push this into master?
Flags: needinfo?(khu)
I don't see any concern here given the impact of the content. But hope we can land these stuff before feature landing date next time. Ping Fabrice to see if he has any concern.
Flags: needinfo?(khu) → needinfo?(fabrice)
That's fine, feel free to land!
Flags: needinfo?(fabrice)
Attachment #8482360 - Flags: review?(timdream)
Comment on attachment 8482360 [details] [review]
patch for Gaia/master

Unfortunately bug 1060879 is in conflict with this patch. Since the key sounds is really really short, according to bug 964584 comment 20 the uncompressed WAV format is actually better in this use case (smaller file size and decoding effort).

r=me, please convert key sound opus files to WAV before merging.
Attachment #8482360 - Flags: review?(timdream) → review+
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/a4011737faf631127f28d3168df79e4ebe7a5a5f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Pavel, I don't see the special key sound being converted to WAV. Please push a follow-up commit to fix it.

(this one: apps/keyboard/resources/sounds/special.opus)
Flags: needinfo?(pivanov)
Assignee: padamczyk → pivanov
If this is landing and merging, it needs the 2.1 tag. Adding.
feature-b2g: --- → 2.1
You need to log in before you can comment on or make changes to this bug.