1046369 - Add architecture to logged library load errors

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Richard Newman [:rnewman]]

Attachment: Add architecture to logged library load errors. v1

This adds both our built ABI and the device's ABI to our log message, and a little more logging.

It also leaves a handy half-empty 'else' clause in which to add an attempted recovery step if the .so is missing entirely, which I'll do in a separate bug.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8466264 [details] [diff] [review]
Add architecture to logged library load errors. v1

Review of attachment 8466264 [details] [diff] [review]:
-----------------------------------------------------------------

Thought about asking you to move AppConstants into mozglue...

Comment 3

[Richard Newman [:rnewman]]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #2)
> Thought about asking you to move AppConstants into mozglue...

Yeah, I want to; currently we can't use it from /utils, which is annoying. I'll file a bug.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/2ec57560f3cc

Comment 5

[Richard Newman [:rnewman]]

We want this for Beta.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/2ec57560f3cc

Comment 7

[Richard Newman [:rnewman]]

Comment on attachment 8466264 [details] [diff] [review]
Add architecture to logged library load errors. v1

Continuing to hunt down library load errors on Google Play. This is only relevant for Beta and Release.

This is a logging-only change.

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-beta/rev/429123ab0700
http://hg.mozilla.org/releases/mozilla-aurora/rev/1432d5e16098