Closed Bug 1046369 Opened 5 years ago Closed 5 years ago

Add architecture to logged library load errors

Categories

(Firefox for Android :: General, defect, critical)

31 Branch
All
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 34
Tracking Status
firefox32 --- fixed
firefox33 --- fixed
firefox34 --- fixed
fennec 32+ ---

People

(Reporter: rnewman, Assigned: rnewman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
This adds both our built ABI and the device's ABI to our log message, and a little more logging.

It also leaves a handy half-empty 'else' clause in which to add an attempted recovery step if the .so is missing entirely, which I'll do in a separate bug.
Attachment #8466264 - Flags: review?(blassey.bugs)
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Comment on attachment 8466264 [details] [diff] [review]
Add architecture to logged library load errors. v1

Review of attachment 8466264 [details] [diff] [review]:
-----------------------------------------------------------------

Thought about asking you to move AppConstants into mozglue...
Attachment #8466264 - Flags: review?(blassey.bugs) → review+
(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #2)
> Thought about asking you to move AppConstants into mozglue...

Yeah, I want to; currently we can't use it from /utils, which is annoying. I'll file a bug.
We want this for Beta.
tracking-fennec: --- → 32+
Flags: needinfo?(rnewman)
https://hg.mozilla.org/mozilla-central/rev/2ec57560f3cc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Comment on attachment 8466264 [details] [diff] [review]
Add architecture to logged library load errors. v1

Continuing to hunt down library load errors on Google Play. This is only relevant for Beta and Release.

This is a logging-only change.
Attachment #8466264 - Flags: approval-mozilla-beta?
Attachment #8466264 - Flags: approval-mozilla-aurora?
Flags: needinfo?(rnewman)
Attachment #8466264 - Flags: approval-mozilla-beta?
Attachment #8466264 - Flags: approval-mozilla-beta+
Attachment #8466264 - Flags: approval-mozilla-aurora?
Attachment #8466264 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.