1046380 - mozdevice's dmcli should have a command to get a temporary storage area (aka the deviceroot)

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

For bug 1015382 it would be useful to get the temporary storage area using the command line client. This could also be useful for debugging.

Comment 1

[William Lachance (:wlach)]

Attachment: Patch to add functionality

With this patch applied you can do this:

(mozbase)wlach@popsicle:~/src/mozilla-central-hg/testing/mozbase$ dm deviceroot/storage/sdcard0/tests

Comment 2

[Armen [:armenzg]]

Comment on attachment 8464990 [details] [diff] [review]
Patch to add functionality

Review of attachment 8464990 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/09b0fd7d8261

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/09b0fd7d8261

Comment 5

[William Lachance (:wlach)]

Eugh, my original implementation put the result in standard error, which wasn't what we wanted. We want to put the output in standard output, so we can use it later (e.g. as input to another dm command, which we want for eideticker).

Comment 6

[William Lachance (:wlach)]

Attachment: Update to patch

Feeling a bit embarassed I didn't catch this before landing.

Comment 7

[Armen [:armenzg]]

Comment on attachment 8468886 [details] [diff] [review]
Update to patch

Review of attachment 8468886 [details] [diff] [review]:
-----------------------------------------------------------------

It happens.

Comment 8

[William Lachance (:wlach)]

Please check in https://bugzilla.mozilla.org/attachment.cgi?id=8468886 . Note that no try run is necessary as nothing in the build/test cycle uses this functionality. I have run a quick test by myself to make sure it works as expected.

Comment 9

[Armen [:armenzg]]

I will land this.

Comment 10

[Armen [:armenzg]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/553f3204be32

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/553f3204be32