Closed
Bug 1046405
Opened 12 years ago
Closed 12 years ago
Don't merge text_color_primary declaration with `grunt export`
Categories
(Firefox for Android Graveyard :: Search Activity, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Margaret, Assigned: eedens)
References
Details
Attachments
(1 file)
Bug 1035642 added a text_color_primary declaration to search_colors.xml in order to build the search widget separately from Fennec, but `grunt export` is merging that color value in with Fennec's existing resources, causing a packaging error.
I manually removed this from the patch that I landed on fx-team, but we should figure out a way to not need to manually remove this whenever we generate a patch.
|
Assignee | |
Comment 1•12 years ago
|
||
This change doesn't affect any of the files in MC; here is the PR: https://github.com/ericedens/FirefoxSearch/pull/44.
Assignee: margaret.leibovic → eric.edens
Status: NEW → ASSIGNED
Attachment #8465590 -
Flags: review?(margaret.leibovic)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 8465590 [details] [review]
Grunt changes in GH
Nice, thanks for taking this.
Attachment #8465590 -
Flags: review?(margaret.leibovic) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•