1046533 - Completely wrap subconfigures

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

In bug 903369, I originally wanted to do that, but the msys mangling made that hard to do. However, to implement bug 1043268, and possible future improvements, it's actually better to do the effort to overcome the mangling.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Completely wrap subconfigures

While bug 903369 added some kind of wrapping, msys mangling on Windows made
it hard to make the python wrapper invoke subconfigures itself. This change
overcomes this, allowing to run subconfigures entirely independently of
the main configure if necessary, or to do more fancy checks without having
to resort to m4 and shell.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Completely wrap subconfigures

There was a missing "return".

Comment 3

[Mike Hommey [:glandium]]

Attachment: Completely wrap subconfigures

Duh, forgot to remove a debugging thing.

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8465226 [details] [diff] [review]
Completely wrap subconfigures

>+    dnl Yes, this is horrible. But since msys doesn't preserve environment
>+    dnl variables and command line arguments as they are when transitioning
>+    dnl from msys (this script) to python (below), we have to resort to hacks,
>+    dnl storing the environment and command line arguments from a msys process
>+    dnl (perl), and reading it from python.

What guarantee do we have that perl is always msys? Is it just because that's how we have it in MozillaBuild?

>+    print 'configuring in %s' % os.path.relpath(objdir, os.getcwd())
>+    print 'running %s' % ' '.join(command)
>+    sys.stdout.flush()

Did you mean to leave these print statements as well? Not sure if they were just for debugging, or if they're actually useful.

I won't pretend to understand all of the changes, because this is some serious autoconf+perl+python voodoo, but it seems to work as far as I can tell.

Comment 5

[Mike Hommey [:glandium]]

(In reply to Michael Shal [:mshal] from comment #4)
> Comment on attachment 8465226 [details] [diff] [review]
> Completely wrap subconfigures
> 
> >+    dnl Yes, this is horrible. But since msys doesn't preserve environment
> >+    dnl variables and command line arguments as they are when transitioning
> >+    dnl from msys (this script) to python (below), we have to resort to hacks,
> >+    dnl storing the environment and command line arguments from a msys process
> >+    dnl (perl), and reading it from python.
> 
> What guarantee do we have that perl is always msys? Is it just because
> that's how we have it in MozillaBuild?

Yes. And we pretty much don't support building with anything else on windows.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/112cf093670b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/112cf093670b
https://hg.mozilla.org/mozilla-central/rev/759010d95f79