1046592 - Mute option in browser doesn’t work properly.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Juanjo Iglesias]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140716183446

Steps to reproduce:

Step to reproduce the issue: 
1.	Open browser app. 
2.	Go to youtube (http://www.youtube.com)
3.	Play a video in browser window.
4.	Try to mute the video sound pressing the mute button. 

TESTED WITH: 

Flame master , Gecko 10853dd and Gaia cc5af5e.

Tested using unagi 1.3 and unagi 2.0, this option worked properly. 



Actual results:

The video sound isn’t muted. This happens with video is showing in fullscreen or in normal size. 


Expected results:

The video sound should be muted when you pressing the mute button.

Comment 1

[Josh Schmitt [Joshs]]

I am seeing this issue on todays 2.1 Flame 319MB

Environmental Variables:
Device: Flame Master 319MB
Build ID: 20140804040204
Gaia: 5fd14b8bc428f87f9b5cf9cc49f9a4f362a970fb
Gecko: e6614d8d85f9
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

Buttons should always function properly when tapped so nominating this 2.1? This is also a regression from 2.0

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

Mozilla-inbound regression window:

Last Working Environmental Variables:
Device: Flame
Build ID: 20140729092306
Gaia: 449d632c69b1a4bd5101d07d18f76799d3fd5f38
Gecko: eefad3e4e594
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken Environmental Variables:
Device: Flame
Build ID: 20140729094539
Gaia: 449d632c69b1a4bd5101d07d18f76799d3fd5f38
Gecko: 3e28cd6f2ab8
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Gaia is the same again, so it's a Gecko issue.

Gecko pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=eefad3e4e594&tochange=3e28cd6f2ab8

There are quite a few audio related commits. All from the same author.

Comment 4

[Joshua Mitchell (Inactive)]

Paul - this pushlog is all your work - could you take a look?

Comment 5

[Paul Adenot (:padenot)]

Yeah.

Comment 6

[Paul Adenot (:padenot)]

Attachment: Fix volume computation in cubeb's opensl backend. r=

Not sure what I was thinking at the time.

Comment 7

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d830df01b20

Comment 8

[Paul Adenot (:padenot)]

Bustage fix: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1a54f33ef2

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7d830df01b20
https://hg.mozilla.org/mozilla-central/rev/6b1a54f33ef2

Comment 10

[Gabriele Svelto [:gsvelto]]

The commits here seem to be the root cause for bug 1052923. Reverting both of them fixes the problem however I'm unsure if the issue is really caused by this or we miscalculated the volume in the gaia application in the first place.

Comment 11

[Maire Reavy [:mreavy]]

This landed before uplift, so it's already in v2.1.