Closed
Bug 1046848
Opened 11 years ago
Closed 11 years ago
Typo in captivedetect.js:124 nsIHttpActivityOberver
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: valentin, Assigned: valentin)
References
Details
Attachments
(2 files)
|
1.23 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
|
2.31 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
124: QueryInterface: XPCOMUtils.generateQI([Ci.nsIHttpActivityOberver,
125: Ci.nsITimerCallback]),
There is a typo on line 124. It should be ActivityObserver instead of ActivityOberver.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8465559 -
Flags: review?(dolske)
|
||
Updated•11 years ago
|
Attachment #8465559 -
Flags: review?(dolske) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=85488fbd84d7
Captive portal unit tests look good.
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•11 years ago
|
||
Found another typo :)
Attachment #8465874 -
Flags: review?(dolske)
|
|
||
Updated•11 years ago
|
Attachment #8465874 -
Flags: review?(dolske) → review+
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd4d0a467f98
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b4d144c5bdc
Flags: in-testsuite-
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fd4d0a467f98
https://hg.mozilla.org/mozilla-central/rev/6b4d144c5bdc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•