Closed Bug 1046945 Opened 5 years ago Closed 5 years ago

Move ExposeGCThingToActiveJS to js::gc::

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: terrence, Assigned: terrence)

Details

Attachments

(1 file, 1 obsolete file)

We want API consumers to prefer the well-typed ExposeFooToActiveJS and not be passing trace kinds manually. It turns out most already do, so this is pretty much trivial.
Attachment #8465656 - Flags: review?(jcoppeard)
Actually, let me rebase this under the prior patch in my queue /first/, since it seems I missed a few hunks when splitting it out.
Attachment #8465656 - Attachment is obsolete: true
Attachment #8465656 - Flags: review?(jcoppeard)
Attachment #8465725 - Flags: review?(jcoppeard)
Comment on attachment 8465725 [details] [diff] [review]
move_expose_gcthing_to_jsgc-v1.diff

Review of attachment 8465725 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8465725 - Flags: review?(jcoppeard) → review+
Backed out for a suspicious-looking Android crash (sorry, you were afk on IRC, so I decided to play it safe).
https://hg.mozilla.org/integration/mozilla-inbound/rev/ceb3128f93e9

https://tbpl.mozilla.org/php/getParsedLog.php?id=45075649&tree=Mozilla-Inbound
It's really hard to countenance how this trivial name change could have caused crashes. I guess let's ask try?

https://tbpl.mozilla.org/?tree=Try&rev=7c364cc53a3c
Try seems green enough; at least the orange is totally unrelated to JS this time.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cd505eece11
https://hg.mozilla.org/mozilla-central/rev/6cd505eece11
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.