1046945 - Move ExposeGCThingToActiveJS to js::gc::

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: move_expose_gcthing_to_jsgc-v0.diff

We want API consumers to prefer the well-typed ExposeFooToActiveJS and not be passing trace kinds manually. It turns out most already do, so this is pretty much trivial.

Comment 1

[Terrence Cole [:terrence]]

Attachment: move_expose_gcthing_to_jsgc-v1.diff

Actually, let me rebase this under the prior patch in my queue /first/, since it seems I missed a few hunks when splitting it out.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8465725 [details] [diff] [review]
move_expose_gcthing_to_jsgc-v1.diff

Review of attachment 8465725 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 3

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b2dab72041e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for a suspicious-looking Android crash (sorry, you were afk on IRC, so I decided to play it safe).
https://hg.mozilla.org/integration/mozilla-inbound/rev/ceb3128f93e9

https://tbpl.mozilla.org/php/getParsedLog.php?id=45075649&tree=Mozilla-Inbound

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Another on the same push:
https://tbpl.mozilla.org/php/getParsedLog.php?id=45076661&tree=Mozilla-Inbound

Comment 6

[Terrence Cole [:terrence]]

It's really hard to countenance how this trivial name change could have caused crashes. I guess let's ask try?

https://tbpl.mozilla.org/?tree=Try&rev=7c364cc53a3c

Comment 7

[Terrence Cole [:terrence]]

Try seems green enough; at least the orange is totally unrelated to JS this time.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cd505eece11

Comment 8

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/6cd505eece11