1047107 - [EME] CDMProxy needs to Close() its GMPDecryptorProxy on Shutdown

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

The CDMProxy needs to ensure it calls Close() on its GMPDecryptorProxy, else we'll get intermittent crashes during shutdown when the CDMProxy dies before the GMPDecryptorProxy has called its callback Terminated() function. The will then callback the Terminated() function on a stale pointer and crash.

Stack:


>	xul.dll!mozilla::gmp::GMPDecryptorParent::Shutdown() Line 322	C++
 	xul.dll!mozilla::gmp::GMPParent::CloseActive(bool aDieWhenUnloaded=true) Line 192	C++
 	xul.dll!mozilla::gmp::GeckoMediaPluginService::UnloadPlugins() Line 379	C++
 	xul.dll!nsRunnableMethodImpl<void (__thiscall mozilla::gmp::GeckoMediaPluginService::*)(void),void,1>::Run() Line 393	C++
 	xul.dll!nsThreadSyncDispatch::Run() Line 995	C++
 	xul.dll!nsThread::ProcessNextEvent(bool aMayWait=true, bool * aResult=0x0cdffb4f) Line 770	C++
 	xul.dll!NS_ProcessNextEvent(nsIThread * aThread=0x0cb2d500, bool aMayWait=true) Line 265	C++
 	xul.dll!mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate * aDelegate=0x0c67b240) Line 355	C++

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

As discussed in bug 1043147, we need to cancel pending promises when the MediaKeys shutsdown. We also need to cut our connection to the CDM, otherwise it may try to call us back on a stale pointer, and we'll crash on shutdown.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b622e6f97ad

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9b622e6f97ad