1047121 - LSAN leaks when sharing windows via getUserMedia

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

The window-sharing code wasn't freeing up the VideoEngine when exiting.   This led to LSAN leaks that were unnoticed due to leak-checking being broken.

https://tbpl.mozilla.org/?tree=Try&rev=24f65d372a31 for the patch that fixes it.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Release Window-capture VideoEngine when done; clean up shutdown code

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/715b0aee4246

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8465855 [details] [diff] [review]
Release Window-capture VideoEngine when done; clean up shutdown code

Approval Request Comment
[Feature/regressing bug #]: screensharing (master bug alias)

[User impact if declined]: Significant leaks in LSAN (a webrtc VideoEngine and related items) which would need to be added to suppression files.

[Describe test coverage new/current, TBPL]: LSAN tests in the tree will trigger on this now that screen/window sharing tests are active.

[Risks and why]: extremely low; just adds proper cleanup in the same pattern as existing cleanups.

[String/UUID change made/needed]: none

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/715b0aee4246

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b2e3d8e9ea6c

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

minor Mis-merge. bustage fix:
https://hg.mozilla.org/releases/mozilla-aurora/rev/d09fe5c4d537