104719 - Change nsIMsgMailnewsUrl to use attributes instead of getters/setters

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Håkan Waara]

in nsIMsgMailnewsUrl.idl we have lots of SetFoo(in nsIFoo bar) / GetFoo(out
nsIFoo bar). I suggest to simplify this with |attribute nsIFoo bar;|.

This shouldn't break or affect C++, but I will probably have to change some JS code.

Comment 1

[Håkan Waara]

Attachment: patch -- change IDL to be a little smarter

Comment 2

[Håkan Waara]

Surprise, I didn't have to change any callers, so this is merely a tiny IDL change.

I made tabbing/whitespace consistent by making the few spaces be tabs (you want
me to spacify it all intead? ;)

Seeking rs=/sr= from bienvenu or sspitzer

Comment 3

[(not reading, please use [e-mail] instead)]

> Surprise, I didn't have to change any callers

use lxr to double check your changes.

/mailnews/base/resources/content/msgPrintEngine.js, line 62 --
printEngine.SetStatusFeedback(statusFeedback);

Comment 4

[(not reading, please use [e-mail] instead)]

whoops, sorry about that.

that is is from the nsIMsgPrintEngine interface.

I'll go check the rest and then give a review.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 53488 [details] [diff] [review]
patch -- change IDL to be a little smarter

sr=sspitzer

Comment 6

[Håkan Waara]

SetErrorMessage/GetErrorMessage are unused. Can I remove them as well, while I'm
at it?

Comment 7

[David :Bienvenu]

Comment on attachment 53488 [details] [diff] [review]
patch -- change IDL to be a little smarter

r=bienvenu

Comment 8

[Håkan Waara]

Thanks for the reviews guys, and nevermind that last comment; it was used
internally.

Comment 9

[Håkan Waara]

fixed.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

1.22 hwaara%chello.se Oct 15 15:26 #104719, change nsIMsgMailNewsUrl.idl to use
attributes rather than GetFoo/SetFoo.

r=bienvenu, sr=sspitzer

Patch was checked in, marking Verified FIXED.