Closed
Bug 1047204
Opened 10 years ago
Closed 10 years ago
[EME] Implement GMPAudioDecoder interface
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
43.85 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
Implement the GMPAudioDecoder interface to allow using GMPs to decode audio.
Assignee | ||
Updated•10 years ago
|
OS: Windows 8.1 → All
Assignee | ||
Comment 1•10 years ago
|
||
Basically copy the trail blazed by GMPVideoDecoder...
Attachment #8465955 -
Flags: review?(rjesup)
Comment 2•10 years ago
|
||
Comment on attachment 8465955 [details] [diff] [review] Patch v1: Implement GMPAudioDecoder Review of attachment 8465955 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/gmp/GMPAudioDecoderChild.cpp @@ +100,5 @@ > + x.mChannelCount = a.mChannelCount(); > + x.mBitsPerChannel = a.mBitsPerChannel(); > + x.mSamplesPerSecond = a.mSamplesPerSecond(); > + x.mExtraData = a.mExtraData().Elements(); > + x.mExtraDataLen = a.mExtraData().Length(); more descriptive variable names wouldn't be a bad idea.... characters are cheaper than they were 30 years ago @@ +158,5 @@ > + mAudioDecoder->DecodingComplete(); > + mAudioDecoder = nullptr; > + } > + > + //mAudioHost.DoneWithAPI(); remove ::: content/media/gmp/GMPService.cpp @@ +244,5 @@ > NS_IMETHODIMP > +GeckoMediaPluginService::GetGMPAudioDecoder(nsTArray<nsCString>* aTags, > + const nsAString& aOrigin, > + GMPAudioDecoderProxy** aGMPAD) > +{ It seems as if these GetGMPFoo's could all be one function.... or at least a template ::: content/media/gmp/PGMPAudioDecoder.ipdl @@ +21,5 @@ > + InitDecode(GMPAudioCodecData aCodecSettings); > + Decode(GMPAudioEncodedSampleData aInput); > + Reset(); > + Drain(); > + DecodingComplete(); spaces ::: content/media/gmp/mozIGeckoMediaPluginService.idl @@ +62,5 @@ > [noscript] > GMPVideoEncoderProxy getGMPVideoEncoder(in TagArray tags, > [optional] in AString origin, > out GMPVideoHost outVideoHost); > + spaces
Attachment #8465955 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bdb11379d0f
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2bdb11379d0f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•