[EME] Attach crypto info to encoded GMP video frames

RESOLVED FIXED in mozilla34

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

29 Branch
mozilla34
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We need the decryption information that accompanies encoded GMP video frames to be implemented, so that GMPs can decrypt video frames.
(Assignee)

Comment 1

3 years ago
Created attachment 8465956 [details] [diff] [review]
Patch

Initialize GMPEncryptedBufferDataImpl from the output of our demuxer, and ensure that GMPVideoEncodedFrame can store a GMPEncryptedBufferDataImpl.
Attachment #8465956 - Flags: review?(rjesup)
(Assignee)

Updated

3 years ago
Blocks: 1047214
Comment on attachment 8465956 [details] [diff] [review]
Patch

Review of attachment 8465956 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/gmp/GMPVideoEncodedFrameImpl.cpp
@@ +106,5 @@
>    aFrameData.mBuffer() = mBuffer;
>    aFrameData.mBufferType() = mBufferType;
> +  if (mCrypto) {
> +    mCrypto->RelinquishData(aFrameData.mDecryptionData());
> +  }  

spaces
Attachment #8465956 - Flags: review?(rjesup) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dff6f7e6b7e4
https://hg.mozilla.org/mozilla-central/rev/dff6f7e6b7e4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.