1047210 - fix allocation in pkix_pl_CrlDp_Create

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Sachin Kumar Gupta]

Attachment: Proposed Patch.

Error: "Port_ArenaZnew" is a function whose sole duty is to assign memory to its first argument equivalent to "sizeof(2nd argument)"

Here rdnArena is a pointer to a structure  which should be allocated memory equivalent to "sizeof(Certname)", however in current NSS 3.16.3 version it is sizeof(Certname*) which is size of a pointer.


NSS 3.16.3 Version code:

       issuerNameCopy = (CERTName *)PORT_ArenaZNew(rdnArena, CERTName*);

 

Recommended Code:

       issuerNameCopy = (CERTName *)PORT_ArenaZNew(rdnArena, CERTName);

Comment 1

[Kai Engert [:KaiE:]]

Comment on attachment 8465958 [details] [diff] [review]
Proposed Patch.

r=kaie - thanks for the patch!

Comment 2

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nss/rev/11fcf4476c5f

Comment 3

[Wan-Teh Chang]

Comment on attachment 8465958 [details] [diff] [review]
Proposed Patch.

Review of attachment 8465958 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. I verified there is no other bug of this kind.

Kai, please check in this fix for NSS 3.16.4 also.

Comment 4

[Kai Engert [:KaiE:]]

for NSS 3.16.4:
https://hg.mozilla.org/projects/nss/rev/497022ada1ea