1047294 - [Wifi] Device keeps trying to connect to WLAN more than 30 times when connect to WPA-EAP TTLS/PEAP network using wrong server certificate

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Gerry Chang [:gchang]]

+++ This bug was initially created as a clone of Bug #1020212 +++

### Steps:
1. Tap "Manage certificates" > "Import certificate"
2. Select a wrong certificate from sd card
3. Navigate to Settings > Wi-Fi page
4. Choose the network supporting WPA-EAP TTLS/PEAP
5. Select "TTLS" or "PEAP" in EAP method
6. Type username and password
7. Select the wrong certificate imported in step 2
8. Tap "OK" button

### Expected:
Device should not keep trying to connect to WPA-EAP TTLS network

### Actual:
Device keep trying to connect to the wireless network

### Reproduce rate
always

### Version:
Device    flame
Gaia      73fe34db6caad49bf732d7be3ecfca28b482d74f
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/2631725af366
BuildID   20140731160212
Version   32.0

Comment 1

[Gerry Chang [:gchang]]

Attachment: The logs of trying connect to WLAN

Comment 2

[Jason Smith [:jsmith]]

Gerry - Do you think this is a blocker for 2.0 or not?

Comment 3

[Gerry Chang [:gchang]]

Hi Jason,
No, I don't think this is a blocker because the functionality is not broken and it will end trying to connect to the WLAN (after more than 30~50 failures).

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

wpa_supplicant reports CTRL-EVENT-EAP-TLS-CERT-ERROR in a burst in such condition(I don't know why), and even we command it to disable wifi ever 3 failure events, we can't stop it from retrying right away. But the retry should stop eventually.
While capturing the error on my own, I observe some Javascript Error in WifiWorker.js under this rapid event condition, maybe fix them can decrease the retry number a little.

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Fix potential Javascript Error.

Validate ssid string before dequoting, and fix dequoting target.

Test 6 times continuously with retry count of 10, 12, 6, 8, 4, 10.

Comment 6

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8467629 [details] [diff] [review]
Fix potential Javascript Error.

Review of attachment 8467629 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 7

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Fix potential Javascript Error. r=vchang

Add reviewer's name.

Comment 8

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try : https://tbpl.mozilla.org/?tree=Try&rev=5617e25e52cc

Comment 9

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try looks good.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/ee2d8e9da2cd

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ee2d8e9da2cd

Comment 12

[Gerry Chang [:gchang]]

verified @
Gaia      c7f8938522a18454809fb6ea0fd3eddef10a73ea
Gecko     https://hg.mozilla.org/mozilla-central/rev/9eb591a1a203
BuildID   20140814160206
Version   34.0a1