1047301 - SIMD.cpp Clang warnings: comparison of integers of different signs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Clang 3.4.1 with --enable-debug --enable-optimize complains:

/Users/jan/dev/inbound/js/src/builtin/SIMD.cpp:689:36: warning: comparison of integers of different signs: 'int32_t' (aka 'int')
      and 'const uint32_t' (aka 'const unsigned int') [-Wsign-compare]
        if (maskArg < 0 || maskArg > MAX_MASK_VALUE)
                           ~~~~~~~ ^ ~~~~~~~~~~~~~~

/Users/jan/dev/inbound/js/src/builtin/SIMD.cpp:704:36: warning: comparison of integers of different signs: 'int32_t' (aka 'int')
      and 'const uint32_t' (aka 'const unsigned int') [-Wsign-compare]
        if (maskArg < 0 || maskArg > MAX_MASK_VALUE)
                           ~~~~~~~ ^ ~~~~~~~~~~~~~~

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Silence Clang warning about signed/unsigned comparison in SIMD.cpp

It should be a positive int32 in this case.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8466147 [details] [diff] [review]
Silence Clang warning about signed/unsigned comparison in SIMD.cpp

Review of attachment 8466147 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b61ba0db784a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b61ba0db784a