Closed Bug 1047349 Opened 10 years ago Closed 10 years ago

"The update channel has been set correctly. - 'nightly' should equal 'undefined'"

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(firefox34 fixed)

RESOLVED FIXED
Tracking Status
firefox34 --- fixed

People

(Reporter: cosmin-malutan, Assigned: cosmin-malutan)

References

()

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(1 file)

Module: /firefox/lib/software-update.js Test: /testDirectUpdate/test2.js Failure: "The update channel has been set correctly. - 'nightly' should equal 'undefined'" Branches: Default Platforms: All This failed for about 8 times on CI, I could reproduce it locally by the first try, I just downloaded the latest nightly, and ran testrun_update with --channel argument. It seems the latest nightly fails to override the updated channel. https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/07/2014-07-31-03-02-06-mozilla-central/firefox-34.0a1.en-US.linux-x86_64.tar.bz2
Though I could reproduce this I couldn't find the root problem. So far I checked if the mozmill-automation package it sets the channel correctly, and it does. Also if i check the the preference with the command we check in tests it returns the correct value. >Services.prefs.getDefaultBranch("").getCharPref('app.update.channel')
To get this reproduced: Download and activate the latest mozmill env from http://mozqa.com/mozmill-env/ Download and install the build https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/07/2014-07-31-03-02-06-mozilla-central/firefox-34.0a1.en-US.linux-x86_64.tar.bz2 Run: >testrun_update --app=firefox --channel=nightly --target-buildid=20140801030201 --junit=report.xml --workspace=data --report=http://mozmill-crowd.blargon7.com/db/ ~/Builds/Nightly/firefox/firefox
This was a fallout from bug 883120, I ran all testruns except update, my bad. Lets fix it here so I can land it quickly. Thanks Cosmin.
Attached patch patch_v1.0Splinter Review
Since both setting the preference and retrieving was correct it was quite obvious what the problem it was. this.aChannel had to be this.channel otherwise it will always be 'undefined' :))
Assignee: nobody → cosmin.malutan
Status: NEW → ASSIGNED
Attachment #8466212 - Flags: review?(andreea.matei)
Comment on attachment 8466212 [details] [diff] [review] patch_v1.0 Review of attachment 8466212 [details] [diff] [review]: ----------------------------------------------------------------- http://hg.mozilla.org/qa/mozmill-tests/rev/9ba007caff53 (default) Thanks!
Attachment #8466212 - Flags: review?(andreea.matei) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: