1047398 - nsTWeakRef usage in ServiceWorkerManager makes no sense

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Boris Zbarsky [:bzbarsky]]

nsTWeakRef only does something useful if you call forget() on it when the object it's pointing to dies.  In particular, you can only nsTWeakRef an object if the object has an nsTWeakRef member that it notifies when going away.

Clearly using nsTWeakRef<Promise> does NOT fulfill this criterion.  Hence the crashes in serviceworker tests where we do things like QI deleted objects.

Andrea, since nsm is out do you have time to look here by any chance?

Comment 1

[Andrea Marchesini [:baku]]

Attachment: nsTWeakRef.patch

Comment 2

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=5131a4ab5a07

Comment 3

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e697595943c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9e697595943c