Closed
Bug 1047468
Opened 11 years ago
Closed 10 years ago
[rbmozui] Commits tab shows data from the draft for all users, not just owner
Categories
(MozReview Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: smacleod, Assigned: gps)
References
Details
Attachments
(1 file)
The RBMozUI commits tab shows data from the squashed draft for all users.
It makes sense to display draft data to the owner of the review requests, so that they can see what they've pushed and set reviewers before publishing.
In the case of non-owner users we should be showing the currently published data. It would be really confusing for a reviewer to look at the commits tab and see the drafted data which could be quite different from what is currently published.
|
||
Updated•10 years ago
|
Product: bugzilla.mozilla.org → Developer Services
|
Assignee | |
Comment 1•10 years ago
|
||
My understanding is that non-owners won't be able to edit/publish review requests from the commits tab. So, this is a pretty bad UX fail and is thus a P1.
Priority: -- → P1
|
|
Assignee | |
Comment 2•10 years ago
|
||
I'm going to take a stab at this.
Assignee: nobody → gps
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8511355 -
Flags: review?(mconley)
|
|
Assignee | |
Comment 4•10 years ago
|
||
/r/309 - mozreview: don't show the commits tab to non-submitters (bug 1047468)
Pull down this commit:
hg pull review -r 1f5d24eb308d649d11f97f09cb2b36dc82cf8e38
|
||
Updated•10 years ago
|
Attachment #8511355 -
Flags: review?(mconley) → review+
|
|
||
Comment 5•10 years ago
|
||
|
|
Assignee | |
Comment 6•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Updated•9 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•