1047475 - [Messages] The suggestions panel scroll position should be reset after it's been hidden

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. have more than 5 contacts starting with 'a'
2. have more than 5 contacts starting with 'b'
3. open the SMS app and the "new message" panel
4. focus the recipient panel, type 'a'
5. scroll down the suggestions list
5. remove the 'a' character and type 'b'

=> notice the suggestions list is still scrolled down

I don't think we should reset the scroll after each render (after adding/removing each characters), but certainly after it's hidden.

Jenny, what do you think?

Comment 1

[Jenny Lee]

Hello Julien,

Yes I agree that scroll should always be reset after suggestion is hidden.
Also, whenever the names we display on suggestion list is re-rendered, the scroll should be reset too. So if adding/removing character affects the suggestion list, the scroll should always be reset. Tks!

Comment 2

[Julien Wajsberg [:julienw]]

The difficult part is "if affects the suggestion list" ;)

Jenny, is it good enough if we do it also if it doesn't affect the suggestion list? Or as a first step, do it only after it's hidden as I suggested, and file a separate bug to do the full thing?

Comment 3

[Jenny Lee]

In that case, I prefer reset scroll whenever user add/remove a character even if the suggestion list is not affected ;)

Comment 4

[Julien Wajsberg [:julienw]]

okay, let's do this ! thanks !

Comment 5

[Luke Chang [:lchang] (inactive)]

Trying to take this bug.

Comment 6

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 22829

Hi Steve, It's a simple patch. Thanks in advance.

Comment 7

[Steve Chung [:steveck]]

Comment on attachment 8472259 [details] [review]
Pull Request 22829

Hi Luke, patch works fine but unit test please :)

Comment 8

[Luke Chang [:lchang] (inactive)]

Hi Steve,

I added the unit test. Please check again. Thanks a lot.

Comment 9

[Steve Chung [:steveck]]

Comment on attachment 8472259 [details] [review]
Pull Request 22829

r=me, thanks for adding the the test case :)

Comment 10

[Luke Chang [:lchang] (inactive)]

landed on master: https://github.com/mozilla-b2g/gaia/commit/efaefc3c1f6c9fa77a1eb7aa4a016fb84c6feb53

Steve, Thanks for reviewing!

Comment 11

[ankit93040]

Hi Steve

shouldn't we uplift these to v2.0 as well?

Thanks!

Comment 12

[Julien Wajsberg [:julienw]]

Let's ask a blocker here.

[Blocking Requested - why for this release]:
* regressed by bug 1034600 
* can be a weird UX for the user

Comment 13

[Steve Chung [:steveck]]

(In reply to Julien Wajsberg [:julienw] (PTO 08/20 -> 09/15; contact schung instead) from comment #12)
> Let's ask a blocker here.
> 
> [Blocking Requested - why for this release]:
> * regressed by bug 1034600 
> * can be a weird UX for the user

Comment 14

[Steve Chung [:steveck]]

Let's wait for triage result, or you could ask for approval instead.

Comment 15

[Preeti Raghunath(:Preeti)]

Backlog, lets do approval.

Comment 16

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8472259 [details] [review]
Pull Request 22829

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): regressed by bug 1034600.
[User impact] if declined: can be a weird UX for the user.
[Testing completed]: TBPL passed.
[Risk to taking this patch] (and alternatives if risky): should be low since it's a very simple patch and already landed on master branch.
[String changes made]: none.

Comment 17

[bhavana bajaj [:bajaj]]

Comment on attachment 8472259 [details] [review]
Pull Request 22829

Making an exception on approval here as this was regressed recently by bug 1034600 in 2.0 and is super low risk

Comment 18

[Luke Chang [:lchang] (inactive)]

uplifted to v2.0: https://github.com/mozilla-b2g/gaia/commit/a6fc290a5601183f84ee9c7cb37eeebc933af2f5

Bhavana, Thanks.

Comment 19

[Paladin]

This issue has been verified successfully on Flame 2.0,2.1

See attachment: Verify_video.3gp
Reproducing rate: 0/5
Flame 2.0 new build:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141208000206
Version         32.0
Flame2.1 build:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0

Comment 20

[Paladin]

Attachment: Verify_video.3gp