Closed
Bug 1047548
Opened 10 years ago
Closed 10 years ago
Qt/No-X builds are failing because of missing Cairo build flags
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: gcp, Assigned: gcp)
Details
Attachments
(1 file)
|
901 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Doing a no-X build is failing for me in cairo-qt-surface.cpp.
After some investigation, the Cairo moz.build file is setting the build flags by modifying CFLAGS, but some of the sources are C++, so CXXFLAGS needs to be modified as well.
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → gpascutto
Attachment #8466351 -
Flags: review?(mh+mozilla)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8466351 [details] [diff] [review]
Patch 1. fix-cpluplus-buildflags
Review of attachment 8466351 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/cairo/cairo/src/moz.build
@@ +226,5 @@
> CFLAGS += CONFIG['XCFLAGS']
>
> if CONFIG['MOZ_ENABLE_CAIRO_FT']:
> + CFLAGS += CONFIG['CAIRO_FT_CFLAGS']
> + CXXFLAGS += CONFIG['CAIRO_FT_CFLAGS']
We usually don't align +=.
Attachment #8466351 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•