Closed Bug 1047572 Opened 5 years ago Closed 5 years ago

Mulet exposed Intl ECMA support when b2g does not

Categories

(Firefox OS Graveyard :: Runtime, defect)

All
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S3 (9jan)

People

(Reporter: bkelly, Assigned: ochameau)

References

Details

Attachments

(1 file)

After enabling mulet builds today we say this:

1565 INFO TEST-UNEXPECTED-FAIL | /tests/dom/workers/test/test_worker_interfaces.html | false: If this is failing: DANGER, are you sure you want to expose the new interface Intl to all webpages as a property on the worker? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

Presumably this would fail in /tests/dom/tests/mochitest/general/test_interfaces.html as well for the main thread if it wasn't disabled for mulet.

According to #jsapi the Intl support is disabled in b2g.  The test checks for this by looking for mobile user agent strings.

If Mulet is enabling Intl support when b2g is not, then this is a bug in Mulet's emulation of the b2g platform.

As this is a new build just working out the kinks, we plan to hide Mulet M4 until this can be fixed.
Aldo, didn't know what category to put this in.  If anyone knows, please fix.
Mulet is a hybrid product between b2g and Firefox, so that there is some side effects like this.
There is multiple issues here.
The user agent for mulet is: "Mozilla/5.0 (X11; Mobile; rv:33.0) Gecko/20100101 Firefox/33.0"
So that isDesktop and isB2G are both false.
We would need to tweak these tests to behave sanely on Mulet.

Otherwise, we can try to disable Intl on Mulet, if Firefox still works without it.
Component: General → Runtime
Comment on attachment 8538515 [details] [diff] [review]
Disable intl on mulet

Review of attachment 8538515 [details] [diff] [review]:
-----------------------------------------------------------------

It doesn't seem to break anything on tests, nor when using it...
So just do whatever we do for b2g.
Attachment #8538515 - Flags: review?(ahalberstadt)
Comment on attachment 8538515 [details] [diff] [review]
Disable intl on mulet

Review of attachment 8538515 [details] [diff] [review]:
-----------------------------------------------------------------

Looks trivial enough to r+, but I'm not a build peer so don't think I'm technically supposed to do that.
Attachment #8538515 - Flags: review?(ahalberstadt) → review?(mh+mozilla)
Attachment #8538515 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9c81cf0a3ebe
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S3 (9jan)
You need to log in before you can comment on or make changes to this bug.