Closed Bug 1047588 Opened 11 years ago Closed 11 years ago

Intermittent 456727-2.html,test_bug611182.html | application crashed [@ mozilla::IMEContentObserver::Init(nsIWidget*, nsPresContext*, nsIContent*)] after "Assertion failure: mEditor (Failed to get editor), at dom/events/IMEContentObserver.cpp:127"

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36
Tracking Flags:
Tracking Status
firefox34 --- wontfix
firefox35 --- fixed
firefox36 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: masayuki)

References

Details

(Keywords: assertion, crash, intermittent-failure)

Attachments

(2 files, 1 obsolete file)

Patch for m-c and Aurora (r=smaug)
14.63 KB, patch
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Patch for Beta (r=smaug)
14.61 KB, patch
lmandel
: approval-mozilla-beta-
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=45055236&tree=Fx-Team Rev5 MacOSX Mountain Lion 10.8 fx-team debug test mochitest-4 on 2014-08-01 07:20:44 PDT for push e6cd9731c679 slave: talos-mtnlion-r5-090 07:27:20 INFO - 14390 INFO ++DOMWINDOW == 86 (0x1281f4000) [pid = 1259] [serial = 1470] [outer = 0x12312ec00] 07:27:20 INFO - 14391 INFO [1259] WARNING: NS_ENSURE_TRUE(selCon) failed: file /builds/slave/fx-team-osx64-d-00000000000000/build/editor/libeditor/base/nsEditor.cpp, line 613 07:27:20 INFO - 14392 INFO [1259] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0xC1F30001: file /builds/slave/fx-team-osx64-d-00000000000000/build/extensions/spellcheck/src/mozInlineSpellChecker.cpp, line 1787 07:27:20 INFO - 14393 INFO [1259] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0xC1F30001: file /builds/slave/fx-team-osx64-d-00000000000000/build/extensions/spellcheck/src/mozInlineSpellChecker.cpp, line 1633 07:27:20 INFO - 14394 INFO [1259] WARNING: NS_ENSURE_TRUE(selection->GetRangeCount()) failed: file /builds/slave/fx-team-osx64-d-00000000000000/build/editor/libeditor/html/nsHTMLEditRules.cpp, line 321 07:27:20 INFO - 14395 INFO [1259] WARNING: NS_ENSURE_TRUE(aSelection->GetRangeCount()) failed: file /builds/slave/fx-team-osx64-d-00000000000000/build/editor/libeditor/base/nsEditor.cpp, line 3836 07:27:20 INFO - 14396 INFO [1259] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/slave/fx-team-osx64-d-00000000000000/build/editor/libeditor/base/nsEditor.cpp, line 3815 07:27:20 INFO - 14397 INFO [1259] WARNING: NS_ENSURE_SUCCESS(res, res) failed with result 0x80004005: file /builds/slave/fx-team-osx64-d-00000000000000/build/editor/libeditor/html/nsHTMLEditRules.cpp, line 8522 07:27:20 INFO - 14398 INFO [1259] WARNING: NS_ENSURE_TRUE(editor) failed: file /builds/slave/fx-team-osx64-d-00000000000000/build/editor/libeditor/base/nsEditorCommands.cpp, line 549 07:27:20 INFO - 14399 INFO [1259] WARNING: '!sPresContext', file /builds/slave/fx-team-osx64-d-00000000000000/build/dom/events/IMEStateManager.cpp, line 586 07:27:20 INFO - 14400 INFO [1259] WARNING: NS_ENSURE_TRUE(mDisabledJSAndPlugins) failed: file /builds/slave/fx-team-osx64-d-00000000000000/build/editor/composer/nsEditingSession.cpp, line 208 07:27:20 INFO - 14401 INFO Assertion failure: mEditor (Failed to get editor), at /builds/slave/fx-team-osx64-d-00000000000000/build/dom/events/IMEContentObserver.cpp:127 07:27:20 INFO - 14402 INFO nsEditorEventListener::Focus(nsIDOMEvent*) [xpcom/glue/nsCOMPtr.h:525] 07:27:20 INFO - 14403 INFO nsEditorEventListener::HandleEvent(nsIDOMEvent*) [editor/libeditor/base/nsEditorEventListener.cpp:346] 07:27:20 INFO - 14404 INFO mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, nsIDOMEvent*, mozilla::dom::EventTarget*) [dom/events/EventListenerManager.cpp:948] 07:27:20 INFO - 14405 INFO mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, nsIDOMEvent**, mozilla::dom::EventTarget*, nsEventStatus*) [dom/events/EventListenerManager.cpp:1009] 07:27:20 INFO - 14406 INFO mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) [dom/events/EventDispatcher.cpp:203] 07:27:20 INFO - 14407 INFO mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) [dom/events/EventDispatcher.cpp:294] 07:27:20 INFO - 14408 INFO mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, nsIDOMEvent*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsCOMArray<mozilla::dom::EventTarget>*) [dom/events/EventDispatcher.cpp:607] 07:27:20 INFO - 14409 INFO FocusBlurEvent::Run() [dom/base/nsFocusManager.cpp:1877] 07:27:20 INFO - 14410 INFO nsContentUtils::AddScriptRunner(nsIRunnable*) [content/base/src/nsContentUtils.cpp:5106] 07:27:20 INFO - 14411 INFO nsFocusManager::SendFocusOrBlurEvent(unsigned int, nsIPresShell*, nsIDocument*, nsISupports*, unsigned int, bool, bool) [xpcom/glue/nsCOMPtr.h:525] 07:27:20 INFO - 14412 INFO nsFocusManager::Focus(nsPIDOMWindow*, nsIContent*, unsigned int, bool, bool, bool, bool) [xpcom/glue/nsCOMPtr.h:829] 07:27:20 INFO - 14413 INFO nsFocusManager::WindowShown(nsIDOMWindow*, bool) [xpcom/glue/nsCOMPtr.h:525] 07:27:20 INFO - 14414 INFO nsGlobalWindow::SetReadyForFocus() [dom/base/nsGlobalWindow.cpp:10063] 07:27:20 INFO - 14415 INFO nsGlobalWindow::SetReadyForFocus() [dom/base/nsGlobalWindow.cpp:10047] 07:27:20 INFO - 14416 INFO PresShell::UnsuppressAndInvalidate() [layout/base/nsPresShell.cpp:3942] 07:27:20 INFO - 14417 INFO PresShell::sPaintSuppressionCallback(nsITimer*, void*) [xpcom/base/nsAutoPtr.h:852] 07:27:20 INFO - 14418 INFO nsTimerImpl::Fire() [xpcom/threads/nsTimerImpl.cpp:634] 07:27:20 INFO - 14419 INFO nsTimerEvent::Run() [xpcom/base/nsAutoPtr.h:836] 07:27:20 INFO - 14420 INFO nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:766] 07:27:20 INFO - 14421 INFO NS_ProcessPendingEvents(nsIThread*, unsigned int) [xpcom/glue/nsThreadUtils.cpp:207] 07:27:20 INFO - 14422 INFO nsBaseAppShell::NativeEventCallback() [widget/xpwidgets/nsBaseAppShell.cpp:99] 07:27:20 INFO - 14423 INFO nsAppShell::ProcessGeckoEvents(void*) [widget/cocoa/nsAppShell.mm:375] 07:27:20 INFO - 14424 INFO CoreFoundation + 0x12841 07:27:20 INFO - 14425 INFO CoreFoundation + 0x12165 07:27:20 INFO - 14426 INFO CoreFoundation + 0x354e5 07:27:20 INFO - 14427 INFO CoreFoundation + 0x34dd2 07:27:20 INFO - 14428 INFO HIToolbox + 0x5f774 07:27:20 INFO - 14429 INFO HIToolbox + 0x5f512 07:27:20 INFO - 14430 INFO HIToolbox + 0x5f3a3 07:27:20 INFO - 14431 INFO AppKit + 0x156fa3 07:27:20 INFO - 14432 INFO -AppKit + 0x156862 07:27:20 INFO - 14433 INFO -[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] [widget/cocoa/nsAppShell.mm:129] 07:27:20 INFO - 14434 INFO -AppKit + 0x14dc03 07:27:20 INFO - 14435 INFO nsAppShell::Run() [xpcom/glue/nsCOMPtr.h:652] 07:27:20 INFO - 14436 INFO nsAppStartup::Run() [toolkit/components/startup/nsAppStartup.cpp:278] 07:27:20 INFO - 14437 INFO XREMain::XRE_mainRun() [toolkit/xre/nsAppRunner.cpp:4013] 07:27:20 INFO - 14438 INFO XREMain::XRE_main(int, char**, nsXREAppData const*) [toolkit/xre/nsAppRunner.cpp:4084] 07:27:20 INFO - 14439 INFO XRE_main [toolkit/xre/nsAppRunner.cpp:4298] 07:27:20 INFO - 14440 INFO main [browser/app/nsBrowserApp.cpp:282] 07:27:23 INFO - TEST-INFO | Main app process: killed by SIGHUP 07:27:23 INFO - 14441 INFO must wait for load 07:27:23 INFO - 14442 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<html contenteditable>fooz bar</html> 07:27:23 INFO - 14443 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14444 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14445 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14446 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<html contenteditable><body>fooz bar</body></html> 07:27:23 INFO - 14447 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14448 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14449 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14450 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<body contenteditable>fooz bar</body> 07:27:23 INFO - 14451 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14452 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14453 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14454 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<body contenteditable><p>fooz bar</p></body> 07:27:23 INFO - 14455 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14456 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14457 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14458 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<body contenteditable><div>fooz bar</div></body> 07:27:23 INFO - 14459 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14460 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14461 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14462 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<body contenteditable><span>fooz bar</span></body> 07:27:23 INFO - 14463 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14464 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14465 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14466 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<p contenteditable style='outline:none'>fooz bar</p> 07:27:23 INFO - 14467 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14468 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14469 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14470 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<!DOCTYPE html><html><body contenteditable>fooz bar</body></html> 07:27:23 INFO - 14471 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14472 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14473 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14474 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<!DOCTYPE html><html contenteditable><body>fooz bar</body></html> 07:27:23 INFO - 14475 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14476 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14477 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14478 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:application/xhtml+xml,<html xmlns="http://www.w3.org/1999/xhtml"><body contenteditable="true">fooz bar</body></html> 07:27:23 INFO - 14479 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14480 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14481 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14482 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:application/xhtml+xml,<html xmlns="http://www.w3.org/1999/xhtml" contenteditable="true"><body>fooz bar</body></html> 07:27:23 INFO - 14483 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14484 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14485 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14486 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<body onload="document.designMode='on'">fooz bar</body> 07:27:23 INFO - 14487 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Failed to find the text node 07:27:23 INFO - 14488 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Backspace should work correctly 07:27:23 INFO - 14489 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | No bogus node should exist in the document 07:27:23 INFO - 14490 INFO TEST-PASS | /tests/editor/libeditor/html/tests/test_bug611182.html | Testing data:text/html,<html><script>onload = function() {var old = document.body;old.parentNode.removeChild(old);var r = document.documentElement;var b = document.createElement("body");r.appendChild(b);b.appendChild(document.createTextNode("fooz bar"));b.contentEditable = "true";};</script><body></body></html> 07:27:23 WARNING - TEST-UNEXPECTED-FAIL | /tests/editor/libeditor/html/tests/test_bug611182.html | application terminated with exit code 1 07:27:23 INFO - runtests.py | Application ran for: 0:05:12.108373 07:27:23 INFO - zombiecheck | Reading PID log: /var/folders/8x/s003nh4n1r59l9v6cdkbfbg400000w/T/tmpUX7lJjpidlog 07:27:38 WARNING - PROCESS-CRASH | /tests/editor/libeditor/html/tests/test_bug611182.html | application crashed [@ mozilla::IMEContentObserver::Init(nsIWidget*, nsPresContext*, nsIContent*)] 07:27:38 INFO - Crash dump filename: /var/folders/8x/s003nh4n1r59l9v6cdkbfbg400000w/T/tmpZH8xoG.mozrunner/minidumps/516050A1-7DD2-4223-B38D-1B6AB5A34EC3.dmp 07:27:38 INFO - Operating system: Mac OS X 07:27:38 INFO - 10.8.0 12A269 07:27:38 INFO - CPU: amd64 07:27:38 INFO - family 6 model 42 stepping 7 07:27:38 INFO - 8 CPUs 07:27:38 INFO - Crash reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS 07:27:38 INFO - Crash address: 0x0 07:27:38 INFO - Thread 0 (crashed) 07:27:38 INFO - 0 XUL!mozilla::IMEContentObserver::Init(nsIWidget*, nsPresContext*, nsIContent*) [nsIContent.h:e6cd9731c679 : 1004 + 0x0] 07:27:38 INFO - rbx = 0x00007fff79a5ac68 r12 = 0x0000000122c74020 07:27:38 INFO - r13 = 0x0000000000000000 r14 = 0x0000000122c74030 07:27:38 INFO - r15 = 0x000000012725a800 rip = 0x00000001028b3aeb 07:27:38 INFO - rsp = 0x00007fff5fbfc760 rbp = 0x00007fff5fbfc810 07:27:38 INFO - Found by: given as instruction pointer in context 07:27:38 INFO - 1 XUL!mozilla::IMEStateManager::CreateIMEContentObserver() [IMEStateManager.cpp:e6cd9731c679 : 1155 + 0xb] 07:27:38 INFO - rbx = 0x0000000122c73fc0 r12 = 0x0000000000000000 07:27:38 INFO - r13 = 0x0000000123062f70 r14 = 0x0000000123062f70 07:27:38 INFO - r15 = 0x000000010e893e20 rip = 0x00000001028b7c7a 07:27:38 INFO - rsp = 0x00007fff5fbfc820 rbp = 0x00007fff5fbfc840 07:27:38 INFO - Found by: call frame info 07:27:38 INFO - 2 XUL!nsEditorEventListener::Focus(nsIDOMEvent*) [nsEditorEventListener.cpp:e6cd9731c679 : 945 + 0x4] 07:27:38 INFO - rbx = 0x0000000000000000 r12 = 0x0000000000000000 07:27:38 INFO - r13 = 0x0000000123062f70 r14 = 0x0000000123062f70 07:27:38 INFO - r15 = 0x000000010e893e20 rip = 0x000000010317a8d0 07:27:38 INFO - rsp = 0x00007fff5fbfc850 rbp = 0x00007fff5fbfc8d0 07:27:38 INFO - Found by: call frame info 07:27:38 INFO - 3 XUL!nsEditorEventListener::HandleEvent(nsIDOMEvent*) [nsEditorEventListener.cpp:e6cd9731c679 : 346 + 0xb] 07:27:38 INFO - rbx = 0x0000000000000000 r12 = 0x00007fff5fbfc8e8 07:27:38 INFO - r13 = 0x0000000123062f70 r14 = 0x000000010e893e20 07:27:38 INFO - r15 = 0x0000000123062f70 rip = 0x0000000103177903 07:27:38 INFO - rsp = 0x00007fff5fbfc8e0 rbp = 0x00007fff5fbfc9c0 07:27:38 INFO - Found by: call frame info 07:27:38 INFO - 4 XUL!mozilla::EventListenerManager::HandleEventSubType(mozilla::EventListenerManager::Listener*, nsIDOMEvent*, mozilla::dom::EventTarget*) [EventListenerManager.cpp:e6cd9731c679 : 948 + 0xc] 07:27:38 INFO - rbx = 0x000000012822b5c0 r12 = 0x0000000123062f71 07:27:38 INFO - r13 = 0x0000000123062f70 r14 = 0x000000010fb13430 07:27:38 INFO - r15 = 0x000000010e893e20 rip = 0x00000001028a18c4 07:27:38 INFO - rsp = 0x00007fff5fbfc9d0 rbp = 0x00007fff5fbfca20 07:27:38 INFO - Found by: call frame info 07:27:38 INFO - 5 XUL!mozilla::EventListenerManager::HandleEventInternal(nsPresContext*, mozilla::WidgetEvent*, nsIDOMEvent**, mozilla::dom::EventTarget*, nsEventStatus*) [EventListenerManager.cpp:e6cd9731c679 : 1009 + 0x1d] 07:27:38 INFO - rbx = 0x000000012822b402 r12 = 0x00007fff5fbfcce8 07:27:38 INFO - r13 = 0x0000000000000037 r14 = 0x00007fff5fbfcd40 07:27:38 INFO - r15 = 0x000000010572d090 rip = 0x00000001028a1c9f 07:27:38 INFO - rsp = 0x00007fff5fbfca30 rbp = 0x00007fff5fbfcae0 07:27:38 INFO - Found by: call frame info 07:27:38 INFO - 6 XUL!mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) [EventListenerManager.h:e6cd9731c679 : 328 + 0x7] 07:27:38 INFO - rbx = 0x000000010fb13430 r12 = 0x00007fff5fbfcc50 07:27:38 INFO - r13 = 0x00007fff5fbfcbc8 r14 = 0x00007fff5fbfcbc8 07:27:38 INFO - r15 = 0x000000010e8d7008 rip = 0x00000001028a4cb1 07:27:38 INFO - rsp = 0x00007fff5fbfcaf0 rbp = 0x00007fff5fbfcb10 07:27:38 INFO - Found by: call frame info 07:27:38 INFO - 7 XUL!mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) [EventDispatcher.cpp:e6cd9731c679 : 292 + 0xe] 07:27:38 INFO - rbx = 0x000000010e8d7000 r12 = 0x0000000000000000 07:27:38 INFO - r13 = 0x00007fff5fbfcbc8 r14 = 0x00007fff5fbfcc48 07:27:38 INFO - r15 = 0x000000010e8d7008 rip = 0x000000010289bc5c 07:27:38 INFO - rsp = 0x00007fff5fbfcb20 rbp = 0x00007fff5fbfcb80 07:27:38 INFO - Found by: call frame info 07:27:38 INFO - 8 XUL!mozilla::EventDispatcher::Dispatch(nsISupports*, nsPresContext*, mozilla::WidgetEvent*, nsIDOMEvent*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsCOMArray<mozilla::dom::EventTarget>*) [EventDispatcher.cpp:e6cd9731c679 : 604 + 0xb] 07:27:38 INFO - rbx = 0x000000012725a000 r12 = 0x000000010e8d7300 07:27:38 INFO - r13 = 0x0000000000000000 r14 = 0x0000000000000000 07:27:38 INFO - r15 = 0x000000010e8d7300 rip = 0x000000010289d3c8 07:27:38 INFO - rsp = 0x00007fff5fbfcb90 rbp = 0x00007fff5fbfccd0 07:27:38 INFO - Found by: call frame info 07:27:38 INFO - 9 XUL!FocusBlurEvent::Run() [nsFocusManager.cpp:e6cd9731c679 : 1877 + 0x17] 07:27:38 INFO - rbx = 0x00000001152ebd40 r12 = 0x00007fff5fbfcd58 07:27:38 INFO - r13 = 0x000000010640dae0 r14 = 0x00000001064432f0 07:27:38 INFO - r15 = 0x00007fff5fbfcce8 rip = 0x0000000102115400 07:27:38 INFO - rsp = 0x00007fff5fbfcce0 rbp = 0x00007fff5fbfcda0 07:27:38 INFO - Found by: call frame info 07:27:38 INFO - 10 XUL!nsContentUtils::AddScriptRunner(nsIRunnable*) [nsContentUtils.cpp:e6cd9731c679 : 5106 + 0x5] 07:27:38 INFO - rbx = 0x00000001152ebd40 r12 = 0x00000001152ebd58 07:27:38 INFO - r13 = 0x000000012725a000 r14 = 0x00007fff5fbfcdb0 07:27:38 INFO - r15 = 0x0000000000000514 rip = 0x0000000102ceaea4 07:27:38 INFO - rsp = 0x00007fff5fbfcdb0 rbp = 0x00007fff5fbfcdd0 07:27:38 INFO - Found by: call frame info
All of them failed in this case: <html> <script> onload = function() { var old = document.body; old.parentNode.removeChild(old); var r = document.documentElement; var b = document.createElement("body"); r.appendChild(b); b.appendChild(document.createTextNode("fooz bar")); b.contentEditable = "true"; }; </script> <body> </body> </html>
Hmm, they hit here before crash: http://mxr.mozilla.org/mozilla-central/source/dom/events/IMEStateManager.cpp#586 > 565 void > 566 IMEStateManager::UpdateIMEState(const IMEState& aNewIMEState, > 567 nsIContent* aContent) > 568 { > 569 PR_LOG(sISMLog, PR_LOG_ALWAYS, > 570 ("ISM: IMEStateManager::UpdateIMEState(aNewIMEState={ mEnabled=%s, " > 571 "mOpen=%s }, aContent=0x%p), " > 572 "sPresContext=0x%p, sContent=0x%p, sActiveIMEContentObserver=0x%p, " > 573 "sIsGettingNewIMEState=%s", > 574 GetIMEStateEnabledName(aNewIMEState.mEnabled), > 575 GetIMEStateSetOpenName(aNewIMEState.mOpen), aContent, > 576 sPresContext, sContent, sActiveIMEContentObserver, > 577 GetBoolName(sIsGettingNewIMEState))); > 578 > 579 if (sIsGettingNewIMEState) { > 580 PR_LOG(sISMLog, PR_LOG_DEBUG, > 581 ("ISM: IMEStateManager::UpdateIMEState(), " > 582 "does nothing because of called while getting new IME state")); > 583 return; > 584 } > 585 > 586 if (NS_WARN_IF(!sPresContext)) { > 587 PR_LOG(sISMLog, PR_LOG_ERROR, > 588 ("ISM: IMEStateManager::UpdateIMEState(), FAILED due to " > 589 "no managing nsPresContext")); > 590 return; > 591 } I've not understood the cause yet, but this must be a big hint. It means nsFocusManager hasn't called IMEStateManager::OnChangeFocus() with proper nsPresContext.
https://tbpl.mozilla.org/php/getParsedLog.php?id=47029420&tree=Mozilla-Inbound
Summary: Intermittent test_bug611182.html | application crashed [@ mozilla::IMEContentObserver::Init(nsIWidget*, nsPresContext*, nsIContent*)] after "Assertion failure: mEditor (Failed to get editor), at dom/events/IMEContentObserver.cpp:127" → Intermittent 456727-2.html,test_bug611182.html | application crashed [@ mozilla::IMEContentObserver::Init(nsIWidget*, nsPresContext*, nsIContent*)] after "Assertion failure: mEditor (Failed to get editor), at dom/events/IMEContentObserver.cpp:127"
Anything we can do to get this bug moving again, or should I just go ahead and disable any and all tests that hit it?
Flags: needinfo?(masayuki)
I've taken a look this two days, but still not sure the reason of this. The most complicated thing of this is, its frequency isn't enough to research :-( I'll keep taking a look this tomorrow: The stack trace at crash: > 1104 INFO TEST-PASS | /tests/editor/libeditor/tests/test_bug611182.html | Testing data:text/html,<html><script>onload = function() {var old = document.body;old.parentNode.removeChild(old);var r = document.documentElement;var b = document.createElement("body");r.appendChild(b);b.appendChild(document.createTextNode("fooz bar"));b.contentEditable = "true";};</script><body></body></html> > [1760] WARNING: NS_ENSURE_TRUE(mDisabledJSAndPlugins) failed: file d:\mozilla\mc-a\src\editor\composer\nsEditingSession.cpp, line 209 > Assertion failure: mEditor (Failed to get editor), at d:\mozilla\mc-a\src\dom\events\IMEContentObserver.cpp:136 > #01: mozilla::IMEStateManager::CreateIMEContentObserver (d:\mozilla\mc-a\src\dom\events\imestatemanager.cpp:1199) > #02: nsEditorEventListener::Focus (d:\mozilla\mc-a\src\editor\libeditor\nseditoreventlistener.cpp:1103) > #03: nsEditorEventListener::HandleEvent (d:\mozilla\mc-a\src\editor\libeditor\nseditoreventlistener.cpp:454) > #04: mozilla::EventListenerManager::HandleEventSubType (d:\mozilla\mc-a\src\dom\events\eventlistenermanager.cpp:970) > #05: mozilla::EventListenerManager::HandleEventInternal (d:\mozilla\mc-a\src\dom\events\eventlistenermanager.cpp:1032) > #06: mozilla::EventListenerManager::HandleEvent (d:\mozilla\mc-a\fx-dbg\dist\include\mozilla\eventlistenermanager.h:329) > #07: mozilla::EventTargetChainItem::HandleEvent (d:\mozilla\mc-a\src\dom\events\eventdispatcher.cpp:204) > #08: mozilla::EventTargetChainItem::HandleEventTargetChain (d:\mozilla\mc-a\src\dom\events\eventdispatcher.cpp:295) > #09: mozilla::EventDispatcher::Dispatch (d:\mozilla\mc-a\src\dom\events\eventdispatcher.cpp:609) > #10: FocusBlurEvent::Run (d:\mozilla\mc-a\src\dom\base\nsfocusmanager.cpp:1918) > #11: nsContentUtils::AddScriptRunner (d:\mozilla\mc-a\src\dom\base\nscontentutils.cpp:5070) > #12: nsFocusManager::SendFocusOrBlurEvent (d:\mozilla\mc-a\src\dom\base\nsfocusmanager.cpp:1986) > #13: nsFocusManager::Focus (d:\mozilla\mc-a\src\dom\base\nsfocusmanager.cpp:1803) > #14: nsFocusManager::WindowShown (d:\mozilla\mc-a\src\dom\base\nsfocusmanager.cpp:900) > #15: nsGlobalWindow::SetReadyForFocus (d:\mozilla\mc-a\src\dom\base\nsglobalwindow.cpp:10143) > #16: nsGlobalWindow::SetReadyForFocus (d:\mozilla\mc-a\src\dom\base\nsglobalwindow.cpp:10127) > #17: PresShell::UnsuppressAndInvalidate (d:\mozilla\mc-a\src\layout\base\nspresshell.cpp:4017) > #18: nsTimerImpl::Fire (d:\mozilla\mc-a\src\xpcom\threads\nstimerimpl.cpp:618) > #19: nsTimerEvent::Run (d:\mozilla\mc-a\src\xpcom\threads\nstimerimpl.cpp:716) > #20: nsThread::ProcessNextEvent (d:\mozilla\mc-a\src\xpcom\threads\nsthread.cpp:830) > #21: NS_ProcessNextEvent (d:\mozilla\mc-a\src\xpcom\glue\nsthreadutils.cpp:265) > #22: mozilla::ipc::MessagePump::Run (d:\mozilla\mc-a\src\ipc\glue\messagepump.cpp:99) > #23: MessageLoop::RunInternal (d:\mozilla\mc-a\src\ipc\chromium\src\base\message_loop.cc:233) > #24: MessageLoop::RunHandler (d:\mozilla\mc-a\src\ipc\chromium\src\base\message_loop.cc:227) > #25: MessageLoop::Run (d:\mozilla\mc-a\src\ipc\chromium\src\base\message_loop.cc:201) > #26: nsBaseAppShell::Run (d:\mozilla\mc-a\src\widget\nsbaseappshell.cpp:166) > #27: nsAppShell::Run (d:\mozilla\mc-a\src\widget\windows\nsappshell.cpp:180) > #28: nsAppStartup::Run (d:\mozilla\mc-a\src\toolkit\components\startup\nsappstartup.cpp:282) > #29: XREMain::XRE_mainRun (d:\mozilla\mc-a\src\toolkit\xre\nsapprunner.cpp:4095) > #30: XREMain::XRE_main (d:\mozilla\mc-a\src\toolkit\xre\nsapprunner.cpp:4171) > #31: XRE_main (d:\mozilla\mc-a\src\toolkit\xre\nsapprunner.cpp:4391) > #32: do_main (d:\mozilla\mc-a\src\browser\app\nsbrowserapp.cpp:287) > #33: NS_internal_main (d:\mozilla\mc-a\src\browser\app\nsbrowserapp.cpp:656) > #34: wmain (d:\mozilla\mc-a\src\toolkit\xre\nswindowswmain.cpp:120) > #35: __tmainCRTStartup (f:\dd\vctools\crt\crtw32\startup\crt0.c:255) > #36: BaseThreadInitThunk[KERNEL32 +0x1919f] > #37: RtlInitializeExceptionChain[ntdll +0x50bbb] > #38: RtlInitializeExceptionChain[ntdll +0x50b91] The log around the crash: > 0[2911140]: ISM: IMEStateManager::OnChangeFocus(aPresContext=0x7a4e000, aContent=0x0, aCause=CAUSE_UNKNOWN) > 0[2911140]: ISM: IMEStateManager::OnChangeFocusInternal(aPresContext=0x7a4e000, aContent=0x0, aAction={ mCause=CAUSE_UNKNOWN, mFocusChange=FOCUS_NOT_CHANGED }), sPresContext=0x0, sContent=0x0, sActiveIMEContentObserver=0x0 > 0[2911140]: ISM: IMEStateManager::GetNewIMEState(aPresContext=0x7a4e000, aContent=0x0), sInstalledMenuKeyboardListener=false > 0[2911140]: ISM: IMEStateManager::GetNewIMEState() returns ENABLED because design mode editor has focus > 0[2911140]: ISM: IMEStateManager::SetIMEState(aState={ mEnabled=ENABLED, mOpen=DONT_CHANGE_OPEN_STATE }, aContent=0x0, aWidget=0x7f62800, aAction={ mCause=CAUSE_UNKNOWN, mFocusChange=GOT_FOCUS }) > 0[2911140]: ISM: IMEStateManager::SetIMEState(), calling nsIWidget::SetInputContext(context={ mIMEState={ mEnabled=ENABLED, mOpen=DONT_CHANGE_OPEN_STATE }, mHTMLInputType="", mHTMLInputInputmode="", mActionHint="" }, aAction={ mCause=CAUSE_UNKNOWN_CHROME, mAction=GOT_FOCUS }) > 0[2911140]: ISM: IMEEnabledStateChangedEvent::Run(), notifies observers of "ime-enabled-state-changed" > 0[2911140]: ISM: IMEStateManager::OnFocusInEditor(aPresContext=0x7a4e000, aContent=0x0), sPresContext=0x7a4e000, sContent=0x0, sActiveIMEContentObserver=0x0 > 0[2911140]: ISM: IMEStateManager::CreateIMEContentObserver(), sPresContext=0x7a4e000, sContent=0x0, sActiveIMEContentObserver=0x0, sActiveIMEContentObserver->IsManaging(sPresContext, sContent)=false > 0[2911140]: ISM: IMEStateManager::CreateIMEContentObserver() is creating an IMEContentObserver instance... According to the log, it's strange aContent to be null in this case. This means that no element has focus in the document which is managed by sPresContext=0x7a4e000. Immediately before this, you can see an error at UpdateIMEState(): > 0[2911140]: ISM: IMEStateManager::OnChangeFocus(aPresContext=0x16335400, aContent=0x0, aCause=CAUSE_UNKNOWN) > 0[2911140]: ISM: IMEStateManager::OnChangeFocusInternal(aPresContext=0x16335400, aContent=0x0, aAction={ mCause=CAUSE_UNKNOWN, mFocusChange=FOCUS_NOT_CHANGED }), sPresContext=0x0, sContent=0x0, sActiveIMEContentObserver=0x0 > 0[2911140]: ISM: IMEStateManager::GetNewIMEState(aPresContext=0x16335400, aContent=0x0), sInstalledMenuKeyboardListener=false > 0[2911140]: ISM: IMEStateManager::GetNewIMEState() returns DISABLED because no content has focus > 0[2911140]: ISM: IMEStateManager::SetIMEState(aState={ mEnabled=DISABLED, mOpen=DONT_CHANGE_OPEN_STATE }, aContent=0x0, aWidget=0x7f62800, aAction={ mCause=CAUSE_UNKNOWN, mFocusChange=LOST_FOCUS }) > 0[2911140]: ISM: IMEStateManager::SetIMEState(), calling nsIWidget::SetInputContext(context={ mIMEState={ mEnabled=DISABLED, mOpen=DONT_CHANGE_OPEN_STATE }, mHTMLInputType="", mHTMLInputInputmode="", mActionHint="" }, aAction={ mCause=CAUSE_UNKNOWN_CHROME, mAction=LOST_FOCUS }) > 0[2911140]: ISM: IMEStateManager::OnChangeFocus(aPresContext=0x16335400, aContent=0x15e05c80, aCause=CAUSE_UNKNOWN) > 0[2911140]: ISM: IMEStateManager::OnChangeFocusInternal(aPresContext=0x16335400, aContent=0x15e05c80, aAction={ mCause=CAUSE_UNKNOWN, mFocusChange=FOCUS_NOT_CHANGED }), sPresContext=0x16335400, sContent=0x0, sActiveIMEContentObserver=0x0 > 0[2911140]: ISM: IMEStateManager::NotifyIME(aMessage=REQUEST_TO_COMMIT_COMPOSITION, aWidget=0x7f62800), composition=0x0, composition->IsSynthesizedForTests()=false > 0[2911140]: ISM: IMEStateManager::GetNewIMEState(aPresContext=0x16335400, aContent=0x15e05c80), sInstalledMenuKeyboardListener=false > 0[2911140]: ISM: IMEStateManager::GetNewIMEState() returns { mEnabled=ENABLED, mOpen=DONT_CHANGE_OPEN_STATE } > 0[2911140]: ISM: IMEStateManager::SetIMEState(aState={ mEnabled=ENABLED, mOpen=DONT_CHANGE_OPEN_STATE }, aContent=0x15e05c80, aWidget=0x7f62800, aAction={ mCause=CAUSE_UNKNOWN, mFocusChange=GOT_FOCUS }) > 0[2911140]: ISM: IMEStateManager::SetIMEState(), calling nsIWidget::SetInputContext(context={ mIMEState={ mEnabled=ENABLED, mOpen=DONT_CHANGE_OPEN_STATE }, mHTMLInputType="", mHTMLInputInputmode="", mActionHint="" }, aAction={ mCause=CAUSE_UNKNOWN_CHROME, mAction=GOT_FOCUS }) > 0[2911140]: ISM: IMEEnabledStateChangedEvent::Run(), notifies observers of "ime-enabled-state-changed" > 0[2911140]: ISM: IMEStateManager::OnFocusInEditor(aPresContext=0x16335400, aContent=0x15e05c80), sPresContext=0x16335400, sContent=0x15e05c80, sActiveIMEContentObserver=0x0 > 0[2911140]: ISM: IMEStateManager::CreateIMEContentObserver(), sPresContext=0x16335400, sContent=0x15e05c80, sActiveIMEContentObserver=0x0, sActiveIMEContentObserver->IsManaging(sPresContext, sContent)=false > 0[2911140]: ISM: IMEStateManager::CreateIMEContentObserver() is creating an IMEContentObserver instance... > 0[2911140]: ISM: IMEStateManager::OnChangeFocus(aPresContext=0x16335400, aContent=0x0, aCause=CAUSE_UNKNOWN) > 0[2911140]: ISM: IMEStateManager::OnChangeFocusInternal(aPresContext=0x16335400, aContent=0x0, aAction={ mCause=CAUSE_UNKNOWN, mFocusChange=FOCUS_NOT_CHANGED }), sPresContext=0x16335400, sContent=0x15e05c80, sActiveIMEContentObserver=0x16480980 > 0[2911140]: ISM: IMEStateManager::NotifyIME(aMessage=REQUEST_TO_COMMIT_COMPOSITION, aWidget=0x7f62800), composition=0x0, composition->IsSynthesizedForTests()=false > 0[2911140]: ISM: IMEStateManager::DestroyIMEContentObserver(), sActiveIMEContentObserver=0x16480980 > 0[2911140]: ISM: IMEStateManager::DestroyIMEContentObserver(), destroying the active IMEContentObserver... > 0[2911140]: ISM: IMEStateManager::GetNewIMEState(aPresContext=0x16335400, aContent=0x0), sInstalledMenuKeyboardListener=false > 0[2911140]: ISM: IMEStateManager::GetNewIMEState() returns DISABLED because no content has focus > 0[2911140]: ISM: IMEStateManager::SetIMEState(aState={ mEnabled=DISABLED, mOpen=DONT_CHANGE_OPEN_STATE }, aContent=0x0, aWidget=0x7f62800, aAction={ mCause=CAUSE_UNKNOWN, mFocusChange=LOST_FOCUS }) > 0[2911140]: ISM: IMEStateManager::SetIMEState(), calling nsIWidget::SetInputContext(context={ mIMEState={ mEnabled=DISABLED, mOpen=DONT_CHANGE_OPEN_STATE }, mHTMLInputType="", mHTMLInputInputmode="", mActionHint="" }, aAction={ mCause=CAUSE_UNKNOWN_CHROME, mAction=LOST_FOCUS }) > 0[2911140]: ISM: IMEEnabledStateChangedEvent::Run(), notifies observers of "ime-enabled-state-changed" > 0[2911140]: ISM: IMEStateManager::OnDestroyPresContext(aPresContext=0x16335400), sPresContext=0x16335400, sContent=0x0, sTextCompositions=0x0 > 0[2911140]: ISM: IMEStateManager::DestroyIMEContentObserver(), sActiveIMEContentObserver=0x0 > 0[2911140]: ISM: IMEStateManager::DestroyIMEContentObserver() does nothing > 0[2911140]: ISM: IMEStateManager::GetNewIMEState(aPresContext=0x16335400, aContent=0x0), sInstalledMenuKeyboardListener=false > 0[2911140]: ISM: IMEStateManager::GetNewIMEState() returns DISABLED because no content has focus > 0[2911140]: ISM: IMEStateManager::SetIMEState(aState={ mEnabled=DISABLED, mOpen=DONT_CHANGE_OPEN_STATE }, aContent=0x0, aWidget=0x7f62800, aAction={ mCause=CAUSE_UNKNOWN, mFocusChange=LOST_FOCUS }) > 0[2911140]: ISM: IMEStateManager::SetIMEState(), calling nsIWidget::SetInputContext(context={ mIMEState={ mEnabled=DISABLED, mOpen=DONT_CHANGE_OPEN_STATE }, mHTMLInputType="", mHTMLInputInputmode="", mActionHint="" }, aAction={ mCause=CAUSE_UNKNOWN_CHROME, mAction=LOST_FOCUS }) > 0[2911140]: ISM: IMEStateManager::UpdateIMEState(aNewIMEState={ mEnabled=ENABLED, mOpen=DONT_CHANGE_OPEN_STATE }, aContent=0x0), sPresContext=0x0, sContent=0x0, sActiveIMEContentObserver=0x0, sIsGettingNewIMEState=false > 0[2911140]: ISM: IMEStateManager::UpdateIMEState(), FAILED due to no managing nsPresContext
Flags: needinfo?(masayuki)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #141) > should I just go ahead and disable any and all tests that hit it? If this is too high frequency for you, I guess that it's okay to test them only with opt build. But I don't think that it's good thing to disable them completely.
Attached patch Patch (obsolete) — — Splinter Review
I'm still not 100% sure the cause of this random orange. It hits MOZ_ASSERT() when the document is editable but nsContentUtils::GetHTMLEditor() returns nullptr. It only sometimes occur... At making document editable, the document node becomes editable first. And then, nsDocShell stores nsHTMEditor. nsContentUtils::GetHTMLEditor() gets nsHTMLEditor via nsDocShell. Therefore, this *could* occur, though. When IMEContentObserver is initialized, nsEditor (or nsEditorEventListener) does it via IMEStateManager. So, IMECotentObserver doesn't need to get editor instance via nsDocShell if nsEditor and nsEditorEventListenr send a pointer to focused editor by additional argument. This must be the simplest and safest fix.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Attachment #8516750 - Flags: review?(bugs)
Attachment #8516750 - Flags: review?(bugs) → review+
(In reply to Wes Kocher (:KWierso) from comment #152) > Backed out in > https://hg.mozilla.org/integration/mozilla-inbound/rev/919fe1b47dbb under > suspicion of adding the hazard to the build: > > https://treeherder.mozilla.org/ui/logviewer. > html#?job_id=3601563&repo=mozilla-inbound What does "hazard" mean? It doesn't have problem on tryserver to build it. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=32ed70949b67
Flags: needinfo?(masayuki) → needinfo?(kwierso)
Wasn't yours.
Flags: needinfo?(kwierso)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/07e169afc8aa
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
We'll want to request Aurora and Beta approval on this in a day or two when we have reason to believe that this failure is indeed gone.
status-firefox34: --- → affected
status-firefox35: --- → affected
status-firefox36: --- → fixed
status-firefox-esr31: --- → unaffected
Looks solid, can we get some approval requests? :)
Flags: needinfo?(masayuki)
Approval Request Comment [Feature/regressing bug #]: a bug of fix for Bug 496360 [User impact if declined]: The random orange won't fixed in Aurora and this crash in debug build means that the performance issue of bug 496360 isn't fixed in some cases (All Android users and some Windows users who enables TSF mode). [Describe test coverage new/current, TBPL]:Cannot reproduce this bug easy. However, I cannot reproduce the orange with patched build in tryserver. [Risks and why]: I think that the risk is low because the old code *guesses* the focused editor. However, this patch makes focused editor passes its pointer to each method. [String/UUID change made/needed]: Nothing.
Attachment #8516750 - Attachment is obsolete: true
Flags: needinfo?(masayuki)
Attachment #8519990 - Flags: approval-mozilla-aurora?
Approval Request Comment: See above. This is merged with Beta because the comment in the patch was changed at 35 cycle. The related code isn't different from the previous patch.
Attachment #8519994 - Flags: approval-mozilla-beta?
Comment on attachment 8519994 [details] [diff] [review] Patch for Beta (r=smaug) Unless the fix for bug 496360 introduces a new issue that makes matters worse for our users, we've lived with bug 496360 for 5+ years. Given that we're very late in Beta and this is a non trivial code change, I think we can live with the issue for one more release cycle. I'm marking beta-. I'm setting ni on masayuki in case I've missed something in my evaluation and this bug should be renommed.
Flags: needinfo?(masayuki)
Attachment #8519994 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment on attachment 8519990 [details] [diff] [review] Patch for m-c and Aurora (r=smaug) Can take this on Aurora at least.
Attachment #8519990 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #161) > Comment on attachment 8519994 [details] [diff] [review] > Patch for Beta (r=smaug) > > Unless the fix for bug 496360 introduces a new issue that makes matters > worse for our users, we've lived with bug 496360 for 5+ years. Given that > we're very late in Beta and this is a non trivial code change, I think we > can live with the issue for one more release cycle. I'm marking beta-. I'm > setting ni on masayuki in case I've missed something in my evaluation and > this bug should be renommed. No, I think that you are right. It's crashed only on debug build, so, our users hit only the performance issue.
Flags: needinfo?(masayuki)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: