1047669 - "Download YouTube Videos as MP4" add-on does not show Download drop-down menu with e10s

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[juan becerra [:juanb]]

Download drop-down does not show up in e10s mode.

Steps:
1. On an e10s enabled nightly install:
https://addons.mozilla.org/en-US/firefox/addon/download-youtube/?src=ss
2. Go to youtube.com and look for a video.

Expected: You should see a Download drop-down menu that allows you to download the media in several formats.

Actual: No menu is shown.

It works in non-e10s mode.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

The developer has been notified through AMO, though it looks like they were working on it already.

Comment 2

[u524223]

I used one of your github examples and changed the extension. It mostly works, but xmlhttprequest doesn't work cross-domain inside the sandbox. I couldn't find a way to fix xmlhttprequest and it's important for this extension.

https://www.dropbox.com/s/grtps8pk3qul6ju/firefox-electro.xpi?dl=0

Comment 3

[u524223]

I used Cc['@mozilla.org/xmlextras/xmlhttprequest;1'].createInstance(Ci.nsIXMLHttpRequest)

Comment 4

[u524223]

The xpi I linked before works for non-Vevo videos like this one: http://www.youtube.com/watch?v=xEhaVhta7sI I tested it in the latest Nightly

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

This add-on is based on Greasemonkey, so it looks like we need to make that work first.

Comment 6

[u524223]

The latest update (1.8.1) adds support for e10s. I tested it in Firefox 20, Firefox 36 stable, Firefox 38, latest Firefox Nightly with e10s enabled/disabled.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

I can confirm it's working on Nightly.

Thanks!

Comment 8

[Jim Mathies [:jimm]]

This doesn't appear to be working correctly: I see the added youtube download button but when I click on it nothing happens. No errors are reported in the console.

Comment 9

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #8)
> This doesn't appear to be working correctly: I see the added youtube
> download button but when I click on it nothing happens. No errors are
> reported in the console.

Hmm, after a restart, it appears to work.

Comment 10

[Jim Mathies [:jimm]]

Download YouTube Videos as MP4
Assignee: Jim Mathies
Last update: July 2015
Link to add-on:
https://github.com/gantt/downloadyoutube
Contact info for add-on: email [e-mail] or create a new issue at github.com.
Add-on ID: {b9bfaf1c-a63f-47cd-8b9a-29526ced9060}
How well does it work?: 100%
- the download button is added to content and the context menu displays
- downloading video appears to work
Any obvious performance problems? none
Chromium version: the addon is based on greasemonkey and works where ever that is available

Comment 11

[Jim Mathies [:jimm]]

type:xul

Comment 12

[:shell escalante]

Updating this bug with information on webextensions migration information.

The last contact with the add-on author they were planning to upload the new webextension version before 57 goes to Release.  They had just been waiting for the last few webextension API fixes to land.